-
-
Notifications
You must be signed in to change notification settings - Fork 38
Add metainfo.xml support with symlink for backward compatibility #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: probonopd <[email protected]>
Co-authored-by: probonopd <[email protected]>
Co-authored-by: probonopd <[email protected]>
Co-authored-by: probonopd <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for the current freedesktop.org standard .metainfo.xml file naming convention while maintaining backward compatibility with the legacy .appdata.xml naming. When only one of the two file types exists in usr/share/metainfo/, the tool automatically creates a symlink to ensure both paths work, allowing downstream tools to use either naming convention.
Key changes:
- Checks for both
.appdata.xmland.metainfo.xmlfiles in the metainfo directory - Creates relative symlinks for backward compatibility when only one file type exists
- Updates warning messages to recommend
.metainfo.xmlper current freedesktop.org specification - Enhances error messages with
strerror(errno)for symlink creation failures
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Does this resolve the issue? Please comment. Thanks! |
Implements the symlink approach from PR #55 discussion: when only one of
.appdata.xml(legacy) or.metainfo.xml(current freedesktop.org standard) exists, create a symlink to the other name. This ensures all downstream tools work regardless of which naming convention the AppDir uses.Changes
.appdata.xmland.metainfo.xmlinusr/share/metainfo/.metainfo.xmlper freedesktop.org specstrerror(errno)for symlink failuresBehavior
.appdata.xml.metainfo.xml→.appdata.xmlsymlink.metainfo.xml.appdata.xml→.metainfo.xmlsymlink.metainfo.xmlWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
esm.ubuntu.com/usr/lib/apt/methods/https /usr/lib/apt/methods/https(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.