Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support table block on mobile #7001

Merged
merged 40 commits into from
Dec 23, 2024
Merged

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Dec 17, 2024

Feature Preview

Screenshot 2024-12-20 at 16 21 43 Screenshot 2024-12-20 at 16 22 00
  • show the menu buttons when selecting a cell
    • row action menu
    • column action menu
    • table action menu
      • align
      • set to page width
      • distribute columns evenly
      • duplicate table
      • copy link to block
      • cut
      • copy
      • paste
      • delete
  • table action menu
    • define copy/paste protocol for the table block
    • copy
    • paste
    • cut
      • disable it if no content in clipboard
    • delete
    • insert above / insert below
    • insert left / insert right
    • Bold
    • Text color
    • Cell background color
    • align menu
    • header row / column
    • set to page width / distribute columns evenly
    • duplicate row / column
    • clear content
  • + menu support
  • drag to reorder (implement it in the next PR)
  • resize (implement it in the next PR)
  • tests

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.43%. Comparing base (04a013f) to head (fe9307c).
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7001   +/-   ##
=======================================
  Coverage   64.42%   64.43%           
=======================================
  Files         280      280           
  Lines       10738    10738           
  Branches     1449     1449           
=======================================
+ Hits         6918     6919    +1     
  Misses       3648     3648           
+ Partials      172      171    -1     
Flag Coverage Δ
appflowy_web_app 64.43% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 18, 2024

🥷 Ninja i18n – 🛎️ Translations need to be updated

Project /project.inlang

lint rule new reports level link
Missing translation 196 warning contribute (via Fink 🐦)

@LucasXu0 LucasXu0 merged commit 17c116a into AppFlowy-IO:main Dec 23, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant