Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] test: filter calculations #6530

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Xazin
Copy link
Collaborator

@Xazin Xazin commented Oct 10, 2024

There is a bug that needs to be resolved, the regression test has been added but with the expects commented out at the moment.

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

@Xazin Xazin force-pushed the test/filter-calculations branch from 0c9c4e2 to 79c186f Compare October 11, 2024 00:56
@Xazin Xazin requested a review from appflowy October 14, 2024 12:28
children: [
if (calculation != null)
RemoveCalculationButton(
onTap: () => context.read<CalculationsBloc>().add(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move these onTap callbacks into new functions.

expect(find.text('100'), findsNWidgets(2));
});

// TODO: Uncmoment expects
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it can be removed.

@Xazin Xazin added the v0.7.2 label Oct 17, 2024
@Xazin
Copy link
Collaborator Author

Xazin commented Oct 17, 2024

This will be merged before 0.7.2 release, but requires another PR/changes to fix the filter bug.

@LucasXu0 LucasXu0 added v0.7.3 and removed v0.7.2 labels Oct 22, 2024
@Xazin Xazin removed the v0.7.3 label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants