feat: Components & Groups w. new Muscle structure in Arms & Legs #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkje14
changed the title
melund
requested changes
Oct 30, 2024
|
Let us take the rest of the review tomorrow or next week. Whatever, you prefer. |
|
@melund The component & group PR in AMS has been merged now so there is support for this feature in AMS 8.2 now (Y) |
There was a problem hiding this comment.
Copilot reviewed 43 out of 43 changed files in this pull request and generated no suggestions.
There was a problem hiding this comment.
Copilot reviewed 27 out of 47 changed files in this pull request and generated no suggestions.
Files not reviewed (20)
- Application/Examples/AirlinePassenger/AirlinePassenger.main.any: Language not supported
- Application/Examples/StandingModel/StandingModel.Main.any: Language not supported
- Body/AAUHuman/Arm/Calibration/ArmCal1.any: Language not supported
- Body/AAUHuman/Arm/EvaluateMomentArmsStudy.any: Language not supported
- Body/AAUHuman/Arm/LeftArmMusclesSelectedOutput.any: Language not supported
- Body/AAUHuman/Arm/RightArmMusclesSelectedOutput.any: Language not supported
- Body/AAUHuman/Arm/ShoulderArmModel.root.any: Language not supported
- Body/AAUHuman/Arm/ThoraxWrappingSurfaces.any: Language not supported
- Body/AAUHuman/Arm/ammr_3.0_compatibility_structure.any: Language not supported
- Body/AAUHuman/Arm/armmuscles_for_output.any: Language not supported
- Body/AAUHuman/Arm/levator_scapulae.any: Language not supported
- Body/AAUHuman/Arm/sternocleidomastoid.any: Language not supported
- Body/AAUHuman/Arm/trapezius_clavicular.any: Language not supported
- Body/AAUHuman/Arm/trapezius_scapular.any: Language not supported
- Body/AAUHuman/BodyModels/GenericBodyModel/BodyModel.any: Language not supported
- Body/AAUHuman/BodyModels/GenericBodyModel/BodyModel.config_info.any: Language not supported
- Body/AAUHuman/BodyModels/GenericBodyModel/BodyModel.defaults.any: Language not supported
- Body/AAUHuman/BodyModels/GenericBodyModel/ComponentAndGroupDefinitions.ClassTemplate.any: Language not supported
- Body/AAUHuman/BodyModels/GenericBodyModel/ComponentDefinitions.any: Language not supported
- Body/AAUHuman/BodyModels/GenericBodyModel/ComponentTreeConfig.any: Language not supported
melund
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to implement new
AnyComponentDefinitionsin the BodyModel. This replaces the old implementation with regex searching.New Muscle groups are also implemented with the new
AnyComponentGroupclass.This means that the Arm and Leg models have switched to the same folder structure as the Trunk model.
Individual muscle elements are collected into AnyFolders for AMS version < 8.2 and
AnyComponentGroupfor new AMS versions.The "old" structure with muscles in a flat list can be activated with the new temporary BM switch:
BM_COMPATIBILITY_30_MUSCLE_STRUCTURE- this will create ref objects to allow users to gracefully switch to the new structure.A few side quests got handled also:
...Trunk.Meshfolder inside the...Trunk.Abdominalfolder where it belongs...Trunk.LayerConstraintsinto the...Trunk.Abdominalwhere it belongs...ShoulderArm.Musso all none muscle objects are displayed at the bottom.InterpolFunWithSPar.anyas I believe they are only a debug tool