add support for booting snapshots on LUKS encrypted disk #333
Conversation
|
Thank you very much. Can you also add some description on the setting in the man pages and the readme? |
|
Sure! I will hopefully do it in a couple days |
|
Done, let me know if I need to change anything! |
| list_insmods+=("insmod cryptodisk") | ||
| list_insmods+=("insmod luks") | ||
| list_insmods+=("insmod gcry_rijndael") | ||
| list_insmods+=("insmod gcry_rijndael") |
There was a problem hiding this comment.
I can't speak to the bigger picture of what should and shouldn't be added with insmod, but this particular line is duplicated. Should it be duplicated?
There was a problem hiding this comment.
Sorry for the late reply. Honestly I merely copy-pasted what I saw in my grub.cfg , and apparently also in the related issue the insmod list for the user that opened it contains the same duplication . Anyway I tried to boot a snapshot without the duplication and it works, so I don't really know if it's best to do the same duplication as "default" grub does or not
Fixes #260