Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(accessibility): fix missing alt for img #295

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Dec 19, 2023

Error: An img element must have an alt attribute, except under certain conditions.
Source: Nu Html Checker

@Rotzbua Rotzbua force-pushed the fix_validator_img_alt2 branch from 9b3b614 to 5185f99 Compare December 25, 2023 00:10
Error: An img element must have an alt attribute, except under certain conditions.
Source: Nu Html Checker
@Rotzbua Rotzbua force-pushed the fix_validator_img_alt2 branch from 5185f99 to d1f2b3b Compare January 4, 2024 10:38
Copy link
Member

@keunes keunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems I never submitted my review 🤦Sorry!
I would just rename this, as it's the whole website's menu.

_i18n/en.yml Outdated Show resolved Hide resolved
_includes/nav.html Outdated Show resolved Hide resolved
@keunes
Copy link
Member

keunes commented May 8, 2024

Alt approach is correct: https://www.w3.org/WAI/tutorials/forms/labels/#labeling-buttons

If we want to make the menu properly accessible, we should probably set the aria-expanded attribute when the menu is open.

Rotzbua and others added 2 commits May 9, 2024 03:07
@Rotzbua Rotzbua marked this pull request as draft May 9, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants