resolve two cmake warnings with latest cmake version #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmake 3.31 has deprecated rules for <3.10 resulting in a warning (even as part of spring),
cmake 3.12 is required for c++20 anyways, so bump minimum to 3.12.
I also noticed when building chainbase standalone (not as part of spring) that
(this is actually shown in yellow as a full on warning). Go ahead and set CMP0167 to NEW to silence this warning: hopefully if you're using cmake 3.30+ you are using boost 1.70+. Just enabling this single policy felt lower risk than something like
cmake_minimum_required( VERSION 3.12...3.30 )which would have also made CMP0167 NEW but a lot of other policies NEW too.