Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(562): migrate auth screen to compose #564

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

refactor: update feature-auth screen to compose

a643720
Select commit
Loading
Failed to load commit list.
Open

refactor(562): migrate auth screen to compose #564

refactor: update feature-auth screen to compose
a643720
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Jan 5, 2025 in 0s

3 new issues (0 max.) of at least minor severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 3
           

Complexity increasing per file
==============================
- app-data/src/main/kotlin/co/anitrend/data/favourite/datasource/remote/FavouriteRemoteSource.kt  1
- app-data-edge/src/main/kotlin/co/anitrend/data/edge/genre/datasource/IEdgeGenreStore.kt  1
- android-core/src/main/kotlin/co/anitrend/core/android/views/compose/ComposableViewFactory.kt  2
- app-core/src/main/kotlin/co/anitrend/core/component/content/compose/AniTrendComposition.kt  4
- common-media-ui/src/main/kotlin/co/anitrend/common/media/ui/compose/widget/airing/AiringScheduleText.kt  4
- common-tag-ui/src/main/kotlin/co/anitrend/common/tag/ui/compose/TagComponent.kt  8
- common-media-ui/src/main/kotlin/co/anitrend/common/media/ui/compose/item/MediaCarouselItem.kt  5
- common-media-ui/src/main/kotlin/co/anitrend/common/media/ui/compose/section/MediaSummarySection.kt  5
- feature-media-carousel/src/main/kotlin/co/anitrend/media/carousel/component/compose/CarouselScreen.kt  3
- common-media-ui/src/main/kotlin/co/anitrend/common/media/ui/compose/widget/title/MediaSubTitleText.kt  14
- android-deeplink/src/main/kotlin/co/anitrend/deeplink/provider/FeatureProvider.kt  1
- app-data-edge/src/main/kotlin/co/anitrend/data/edge/genre/datasource/EdgeGenreLocalSource.kt  2
- app-data-edge/src/main/kotlin/co/anitrend/data/edge/navigation/datasource/EdgeNavigationLocalSource.kt  2
- common-media-ui/src/main/kotlin/co/anitrend/common/media/ui/compose/widget/releasing/ReleasingComponent.kt  6
- common-media-ui/src/main/kotlin/co/anitrend/common/media/ui/controller/compose/CarouselController.kt  20
- common-media-ui/src/main/kotlin/co/anitrend/common/media/ui/compose/widget/ranking/RankingComponent.kt  8
- common-medialist-ui/src/main/kotlin/co/anitrend/common/medialist/ui/compose/counter/CounterEditor.kt  2
- common-media-ui/src/main/kotlin/co/anitrend/common/media/ui/compose/item/MediaCompactItem.kt  10
- app-data-edge/src/main/kotlin/co/anitrend/data/edge/navigation/datasource/IEdgeNavigationStore.kt  1
- feature-auth/src/main/kotlin/co/anitrend/auth/component/compose/AuthScreenContent.kt  8
- android-core/src/main/kotlin/co/anitrend/core/android/extensions/ComposeExtensions.kt  3
- android-core/src/main/kotlin/co/anitrend/core/android/compose/design/ContentWrapper.kt  7
- app-data-edge/src/main/kotlin/co/anitrend/data/edge/config/datasource/local/EdgeConfigLocalSource.kt  2
- feature-media-carousel/src/main/kotlin/co/anitrend/media/carousel/component/content/CarouselContent.kt  5
- common-media-ui/src/main/kotlin/co/anitrend/common/media/ui/controller/extensions/RouterExtensions.kt  1
- feature-media-carousel/src/main/kotlin/co/anitrend/media/carousel/component/content/controller/CarouselContentController.kt  1
- common-markdown-ui/src/main/kotlin/co/anitrend/common/markdown/ui/widget/MarkdownTextWidget.kt  3
- app-data-android/src/main/kotlin/co/anitrend/data/android/controller/strategy/contract/ControllerStrategy.kt  1
- feature-media/src/main/kotlin/co/anitrend/media/component/compose/MediaCompose.kt  2
         

Complexity decreasing per file
==============================
+ feature-media-carousel/src/main/kotlin/co/anitrend/media/carousel/koin/Modules.kt  -1
+ feature-profile/src/main/kotlin/co/anitrend/profile/provider/FeatureProvider.kt  -1
+ feature-search/src/main/kotlin/co/anitrend/search/component/screen/SearchScreen.kt  -1
         

Clones added
============
- app-core/src/main/kotlin/co/anitrend/core/component/content/compose/AniTrendComposition.kt  4
- common-media-ui/src/main/kotlin/co/anitrend/common/media/ui/compose/widget/title/MediaSubTitleText.kt  1
- common-media-ui/src/main/kotlin/co/anitrend/common/media/ui/controller/compose/CarouselController.kt  6
- app-data-edge/src/main/kotlin/co/anitrend/data/edge/config/datasource/local/EdgeConfigLocalSource.kt  3
- android-deeplink/src/main/kotlin/co/anitrend/deeplink/component/route/AppRoutes.kt  1
- android-deeplink/src/main/kotlin/co/anitrend/deeplink/component/route/WebRoutes.kt  3
- app-navigation/src/main/kotlin/co/anitrend/navigation/NavigationTargets.kt  1
         

See the complete overview on Codacy

Annotations

Check warning on line 68 in android-core/src/main/kotlin/co/anitrend/core/android/compose/design/image/AniTrendImage.kt

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

android-core/src/main/kotlin/co/anitrend/core/android/compose/design/image/AniTrendImage.kt#L68

Expression with labels increase complexity and affect maintainability.

Check warning on line 56 in app-core/src/main/kotlin/co/anitrend/core/component/content/compose/AniTrendComposition.kt

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app-core/src/main/kotlin/co/anitrend/core/component/content/compose/AniTrendComposition.kt#L56

This empty block of code can be removed.

Check warning on line 27 in common-media-ui/src/main/kotlin/co/anitrend/common/media/ui/controller/compose/CarouselController.kt

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

common-media-ui/src/main/kotlin/co/anitrend/common/media/ui/controller/compose/CarouselController.kt#L27

The function createCarouselData is too long (129). The maximum length is 60.