-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial RPM spec (#1) #4
base: master
Are you sure you want to change the base?
Conversation
Hi! Thank you for the pull request. I don't have any preferences, but rpm package still needs to install the service in the system. This is the expected behavior of virtually any rpm(or deb) package. So... if this is RPM for CentOS 6, it must add SysV-style init scrips (I don't think that rpm packages ever modify user's crontab). If it is RPM for CentOS 7 is must include systemd scripts. Great if it can be both. |
For now, I added the systemd unit -- my standard build environment is CentOS 7 these days. If we need to support both systemd and SysV init, we'd probably want additional packages in the RPM with suffixes I'm not sure if it's worth the effort, though, since systemd seems to be taking over... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Please add a few words about this 'make rpm' target to README.md. Note that it requires systemd. Also I find it a bit strange that we're downloading binary from GitHub release here, can we use a local binary? Thanks.
This adds a new make target
rpm
. Note: therpmdevtools
package is required forrpmbuild
andspectool
.I did not include a systemd unit or crontab (from the SysV install script). Do you have a preference? We can make the systemd unit conditional in the RPM spec if desired.