add: methods to store a seed temporarily #1056
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed if something break along the way and he isn't able to complete his login
superKalo
reviewed
Oct 30, 2024
superKalo
reviewed
Oct 30, 2024
superKalo
reviewed
Oct 30, 2024
… seed didn't get persisted into storage after being moved from temp
borislav-itskov
had a problem deploying
to
tests
GitHub Actions
Failure
borislav-itskov
had a problem deploying
to
tests
GitHub Actions
Failure
superKalo
reviewed
Oct 31, 2024
src/controllers/keystore/keystore.ts
Outdated
| if (shouldUpdate) this.emitUpdate() | ||
| } | ||
|
|
||
| async addTempSeedToKeystoreSeeds() { |
There was a problem hiding this comment.
Please add await this.#initialLoadPromise, just in case.
superKalo
approved these changes
Oct 31, 2024
borislav-itskov
had a problem deploying
to
tests
GitHub Actions
Failure
PetromirDev
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's what we do:
#tempSeedin the keystoreaddSeedToTempin the keystore that will add the seed to temp encrypteddeleteTempSeed- if the user declines to save the seed, we delete it from tempmoveTempSeed- if the user wants the seed stored, we move it to keystoreSeedsThe flow from account adder is as follows:
If the user doesn't complete the login process (rage quits as account personalize), the temp seed remains in the keystore until the user locks his extension or the background process is restarted/reloaded. If the user locks his extension, we delete the temp seed. This is visible in the ambire-app PR (yet to be published)