Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning up remaining todo's in the code #572

Open
wants to merge 12 commits into
base: aip-61-adex-v5
Choose a base branch
from
Open

Cleaning up remaining todo's in the code #572

wants to merge 12 commits into from

Conversation

simzzz
Copy link
Contributor

@simzzz simzzz commented Nov 17, 2022 •
edited
Loading

closes #570

@simzzz simzzz marked this pull request as ready for review November 17, 2022 16:44
@simzzz simzzz requested a review from elpiel November 17, 2022 16:44
elpiel
elpiel requested changes Nov 25, 2022
View reviewed changes
primitives/src/unified_num.rs
@@ -961,6 +955,69 @@ mod test {
);
}
}

#[test]
fn test_unified_num_mod_floor_gcd_lcm_divides_is_multiple_of_div_rem() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm uncertain about these tests. You're actually checking 0.00000008 value in the first test for example, not integers so the math is different for floating numbers.
Another things I realised is that num::Integer allows these methods and it's not implemented for floating numbers, so maybe we don't need to include Integer impl for UnitfiedNum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elpiel elpiel elpiel requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remaining TODO's in the code
2 participants
@simzzz @elpiel