Daniil Krizhanovskyi <[email protected]> #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix NFTSwap.sol - Resolved undeclared variable `_order` issues by mapping it correctly to `nftList`. - Corrected import paths for ERC721 dependencies. - Implemented proper validations for `list`, `purchase`, `revoke`, and `update` methods. - Compiled the contract successfully and verified output artifacts. This closes issue #830.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves the compilation issues in
NFTSwap.soland improves its functionality by:_orderby mapping it correctly tonftList.list: Ensures only the owner can list NFTs and validates the approval.purchase: Checks sufficient payment and proper transfer logic.revoke: Verifies the ownership before revoking an order.update: Ensures only the owner can update the price.What type of PR is this (这是什么类型的PR)
Which issue(s) this PR fixes(Optional) (这个PR 修复了什么问题 (可选择))
What this PR does / why we need it (这个PR 做了什么/ 我们为什么需要这个PR)
This PR fixes the issues that caused the
NFTSwap.solcontract to fail compilation and ensures proper functioning of its core methods for listing, purchasing, revoking, and updating NFT orders.It is critical to fix these issues to maintain functionality and compatibility in the repository.