Merge main into release/12.0.0-next #2639
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Proposed change feat(design): add description to the exploded tokens <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. --> ## Related issues <!-- Please make sure to follow the [contribution guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md) --> *- No issue associated -* <!-- * 🐛 Fix #issue --> <!-- * 🐛 Fix resolves #issue --> <!-- * 🚀 Feature #issue --> <!-- * 🚀 Feature resolves #issue --> <!-- *Pull Request #issue -->
…ly (#2605) ## Proposed change This PR fixes an issue when running tests if tsconfig.json contains more than one item in one of the paths arrays (which is the case when using otter generator for a library). ## Related issue To reproduce the issue (I did it with Otter 11.5.3): ```sh npm create @o3r myproject # (press enter each time a question is asked) cd myproject npm exec ng g library #? Name of the package of the new module? mylib #? Which preset to use to start your application? BASIC - Minimum plugin list to install for a basic Otter application. (details on https://www.npmjs.com/package/@o3r/core#preset-basic) npm exec ng g application #? Name of the new application? myapp #? Which preset to use to start your application? BASIC - Minimum plugin list to install for a basic Otter application. (details on https://www.npmjs.com/package/@o3r/core#preset-basic) # You are currently using jasmine. Do you want to setup Jest test framework? You will have to remove jasmine yourself. yes # Do you want to setup Playwright test framework for E2E? yes ``` Then add a reference to MyLibComponent from `app.component.ts`: ```ts import { Component } from '@angular/core'; import { RouterOutlet } from '@angular/router'; import { MylibComponent } from 'mylib'; // add this line @component({ selector: 'app-root', standalone: true, imports: [RouterOutlet, MylibComponent], // add MylibComponent here templateUrl: './app.component.html', styleUrl: './app.component.scss' }) export class AppComponent { title = 'myapp'; } ``` Then run tests: ``` npm test ``` Tests fail with the following error: ``` > [email protected] test > lerna run test (node:58794) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead. (Use `node --trace-deprecation ...` to show where the warning was created) lerna notice cli v8.1.9 > myapp:test > [email protected] test > jest FAIL myapp src/app/app.component.spec.ts ● Test suite failed to run Configuration error: Could not locate module mylib mapped as: /home/user/myproject/libs/mylib/dist,libs/mylib/src/public-api. Please check your configuration for these entries: { "moduleNameMapper": { "/^mylib$/": "/home/user/myproject/libs/mylib/dist,libs/mylib/src/public-api" }, "resolver": undefined } 1 | import { Component } from '@angular/core'; 2 | import { RouterOutlet } from '@angular/router'; > 3 | import { MylibComponent } from 'mylib'; | ^ 4 | 5 | @component({ 6 | selector: 'app-root', at createNoMappedModuleFoundError (../../node_modules/jest-resolve/build/resolver.js:759:17) at Object.<anonymous> (src/app/app.component.ts:3:1) at Object.<anonymous> (src/app/app.component.spec.ts:2:1) (node:59208) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead. (Use `node --trace-deprecation ...` to show where the warning was created) Test Suites: 1 failed, 1 total Tests: 0 total Snapshots: 0 total Time: 3.072 s Ran all test suites. npm error Lifecycle script `test` failed with error: npm error code 1 npm error path /home/user/myproject/apps/myapp npm error workspace [email protected] npm error location /home/user/myproject/apps/myapp npm error command failed npm error command sh -c jest —————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————— Lerna (powered by Nx) Ran target test for project myapp (4s) ✖ 1/1 failed ✔ 0/1 succeeded [0 read from cache] ``` Note that `tsconfig.json` contains: ```json5 { // ... "compilerOptions": { // ... "paths": { "mylib": [ "libs/mylib/dist", "libs/mylib/src/public-api" ] }, // ... } //... } ```
## Proposed change fix: add missing devDependencies <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. --> ## Related issues <!-- Please make sure to follow the [contribution guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md) --> *- No issue associated -* <!-- * 🐛 Fix #issue --> <!-- * 🐛 Fix resolves #issue --> <!-- * 🚀 Feature #issue --> <!-- * 🚀 Feature resolves #issue --> <!-- *
## Proposed change <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. --> ## Related issues <!-- Please make sure to follow the [contribution guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md) --> *- No issue associated -* <!-- * 🐛 Fix #issue --> <!-- * 🐛 Fix resolves #issue --> <!-- * 🚀 Feature #issue --> <!-- * 🚀 Feature resolves #issue --> <!-- *
## Proposed change <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. --> ## Related issues <!-- Please make sure to follow the [contribution guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md) --> *- No issue associated -* <!-- * 🐛 Fix #issue --> <!-- * 🐛 Fix resolves #issue --> <!-- * 🚀 Feature #issue --> <!-- * 🚀 Feature resolves #issue --> <!-- *
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@typescript-eslint/eslint-plugin](https://typescript-eslint.io/packages/eslint-plugin) ([source](https://redirect.github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin)) | [`~8.17.0` -> `~8.18.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/8.17.0/8.18.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@typescript-eslint/parser](https://typescript-eslint.io/packages/parser) ([source](https://redirect.github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser)) | [`~8.17.0` -> `~8.18.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/8.17.0/8.18.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@typescript-eslint/rule-tester](https://typescript-eslint.io/packages/rule-tester) ([source](https://redirect.github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/rule-tester)) | [`~8.17.0` -> `~8.18.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2frule-tester/8.17.0/8.18.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@typescript-eslint/utils](https://typescript-eslint.io/packages/utils) ([source](https://redirect.github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/utils)) | [`~8.17.0` -> `~8.18.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2futils/8.17.0/8.18.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [typescript-eslint](https://typescript-eslint.io/packages/typescript-eslint) ([source](https://redirect.github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint)) | [`~8.17.0` -> `~8.18.0`](https://renovatebot.com/diffs/npm/typescript-eslint/8.17.0/8.18.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)</summary> ### [`v8.18.0`](https://redirect.github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8180-2024-12-09) [Compare Source](https://redirect.github.com/typescript-eslint/typescript-eslint/compare/v8.17.0...v8.18.0) ##### 🚀 Features - **eslint-plugin:** \[switch-exhaustiveness-check] add support for "no default" comment ([#​10218](https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10218)) - **eslint-plugin:** \[no-deprecated] report on super call of deprecated constructor ([#​10397](https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10397)) ##### 🩹 Fixes - **eslint-plugin:** \[use-unknown-in-catch-callback-variable] only flag function literals ([#​10436](https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10436)) - **eslint-plugin:** \[no-base-to-string] handle more robustly when multiple `toString()` declarations are present for a type ([#​10432](https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10432)) - **eslint-plugin:** \[no-deprecated] check if a JSX attribute is deprecated ([#​10374](https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10374)) - typescript peer dependency ([#​10373](https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10373)) ##### ❤️ Thank You - Kim Sang Du [@​developer-bandi](https://redirect.github.com/developer-bandi) - Kirk Waiblinger [@​kirkwaiblinger](https://redirect.github.com/kirkwaiblinger) - mdm317 - rtritto You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary> ### [`v8.18.0`](https://redirect.github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8180-2024-12-09) [Compare Source](https://redirect.github.com/typescript-eslint/typescript-eslint/compare/v8.17.0...v8.18.0) ##### 🩹 Fixes - typescript peer dependency ([#​10373](https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10373)) ##### ❤️ Thank You - rtritto You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/rule-tester)</summary> ### [`v8.18.0`](https://redirect.github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/rule-tester/CHANGELOG.md#8180-2024-12-09) [Compare Source](https://redirect.github.com/typescript-eslint/typescript-eslint/compare/v8.17.0...v8.18.0) This was a version bump only for rule-tester to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/utils)</summary> ### [`v8.18.0`](https://redirect.github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/utils/CHANGELOG.md#8180-2024-12-09) [Compare Source](https://redirect.github.com/typescript-eslint/typescript-eslint/compare/v8.17.0...v8.18.0) ##### 🩹 Fixes - typescript peer dependency ([#​10373](https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10373)) ##### ❤️ Thank You - rtritto You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>typescript-eslint/typescript-eslint (typescript-eslint)</summary> ### [`v8.18.0`](https://redirect.github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/typescript-eslint/CHANGELOG.md#8180-2024-12-09) [Compare Source](https://redirect.github.com/typescript-eslint/typescript-eslint/compare/v8.17.0...v8.18.0) ##### 🩹 Fixes - typescript peer dependency ([#​10373](https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10373)) ##### ❤️ Thank You - rtritto You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/AmadeusITGroup/otter). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS43Mi41IiwidXBkYXRlZEluVmVyIjoiMzkuNzIuNSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19-->
## Proposed change use posix to compute path for `outputPath` ## Related issues <!-- Please make sure to follow the [contribution guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md) --> <!-- * 🐛 Fix #issue --> * 🐛 Fix resolves #2630 <!-- * 🚀 Feature #issue --> <!-- * 🚀 Feature resolves #issue --> <!-- *
## Proposed change chore: add auto generated yarn ignored files <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. --> ## Related issues <!-- Please make sure to follow the [contribution guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md) --> *- No issue associated -* <!-- * 🐛 Fix #issue --> <!-- * 🐛 Fix resolves #issue --> <!-- * 🚀 Feature #issue --> <!-- * 🚀 Feature resolves #issue --> <!-- *
## Proposed change <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. --> ## Related issues <!-- Please make sure to follow the [contribution guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md) --> *- No issue associated -* <!-- * 🐛 Fix #issue --> <!-- * 🐛 Fix resolves #issue --> <!-- * 🚀 Feature #issue --> <!-- * 🚀 Feature resolves #issue --> <!-- *
fpaul-1A
had a problem deploying
to
development
GitHub Actions
Failure
|
View your CI Pipeline Execution ↗ for commit c8834dc.
☁️ Nx Cloud last updated this comment at |
github-actions
bot
added
bug
vscaiceanu-1a
temporarily deployed
to
development
GitHub Actions
Inactive
vscaiceanu-1a
temporarily deployed
to
development
GitHub Actions
Inactive
vscaiceanu-1a
temporarily deployed
to
development
GitHub Actions
Inactive
vscaiceanu-1a
temporarily deployed
to
development
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Cascade from
maintorelease/12.0.0-next0 conflicts were found when opening this PR
Related issues
- No issue associated -