Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use takeUntilDestroyed instead of subscriptions to unsubscribe #2521

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

matthieu-crouzet
Copy link
Contributor

Proposed change

Use takeUntilDestroyed instead of subscriptions to unsubscribe.

Related issues

@matthieu-crouzet matthieu-crouzet requested a review from a team as a code owner November 27, 2024 14:26
Copy link

codecov bot commented Nov 27, 2024

@matthieu-crouzet matthieu-crouzet force-pushed the feat/use-take-until-destroyed branch from d90b4df to d1be09b Compare November 27, 2024 16:00
fpaul-1A
fpaul-1A previously approved these changes Nov 27, 2024
docs/analytics/TRACK_EVENTS.md Outdated Show resolved Hide resolved
docs/analytics/TRACK_EVENTS.md Show resolved Hide resolved
docs/analytics/TRACK_EVENTS.md Outdated Show resolved Hide resolved
@matthieu-crouzet matthieu-crouzet force-pushed the feat/use-take-until-destroyed branch 4 times, most recently from daa0460 to dd98350 Compare November 29, 2024 08:27
@matthieu-crouzet matthieu-crouzet force-pushed the feat/use-take-until-destroyed branch from dd98350 to ccc266e Compare November 29, 2024 13:37
@matthieu-crouzet matthieu-crouzet force-pushed the feat/use-take-until-destroyed branch from ccc266e to db980d7 Compare December 2, 2024 10:30
@matthieu-crouzet matthieu-crouzet added this pull request to the merge queue Dec 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 3, 2024
@matthieu-crouzet matthieu-crouzet added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit 97db4bd Dec 3, 2024
34 of 35 checks passed
@matthieu-crouzet matthieu-crouzet deleted the feat/use-take-until-destroyed branch December 3, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment