-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use takeUntilDestroyed instead of subscriptions to unsubscribe #2521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e8992c2
to
d90b4df
Compare
fpaul-1A
reviewed
Nov 27, 2024
packages/@o3r/components/src/tools/component-replacement/c11n.directive.ts
Outdated
Show resolved
Hide resolved
d90b4df
to
d1be09b
Compare
fpaul-1A
previously approved these changes
Nov 27, 2024
kpanot
reviewed
Nov 27, 2024
packages/@o3r/rules-engine/src/services/runner/rules-engine.runner.service.ts
Outdated
Show resolved
Hide resolved
daa0460
to
dd98350
Compare
fpaul-1A
reviewed
Nov 29, 2024
apps/chrome-devtools/src/app-devtools/theming-panel/color.pipe.ts
Outdated
Show resolved
Hide resolved
dd98350
to
ccc266e
Compare
ccc266e
to
db980d7
Compare
fpaul-1A
approved these changes
Dec 2, 2024
mrednic-1A
reviewed
Dec 3, 2024
mrednic-1A
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
project:@o3r/analytics
project:@o3r/application
project:@o3r/chrome-devtools
project:@o3r/components
project:@o3r/configuration
project:@o3r/localization
project:@o3r/mobile
project:@o3r/rules-engine
project:@o3r/showcase
project:@o3r/storybook
project:@o3r/styling
project:@o3r/third-party
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Use
takeUntilDestroyed
instead of subscriptions to unsubscribe.Related issues