-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add checkAfterItems in builders #2503
base: release/11.3
Are you sure you want to change the base?
feat: add checkAfterItems in builders #2503
Conversation
dd84a6b
to
3bde229
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with the code but, if we follow the policy, a feature should be pull requested to the main
branch.
We can do exception if the feature is mandatory to process properly to the main purpose of the tool (here the extractors).
It seems to be the case here but, as 11.3
is not the latest major, maybe you will need to move your target to release/11.4
3db3b68
3bde229
to
3db3b68
Compare
Proposed change
Add
checkAfterItems
in metadata-check builder.This new option allows devs to deactivate checks on items set in "after" property.
This will allow documenting breaking changes in modules which don't have access to the complete metadata.
For example with this migration change:
When running builder @o3r/components:check-config-migration-metadata, the metadata file is the one of module @mylib/moduleA and doesn't contain any metadata from other modules (@mylib/moduleB). The check for property "baz" in config interface @mylib/moduleB#Bar will fail.
With the new option
checkAfterItems
, we can deactivate this check.Bonus: Add
packageJsonEntry
in the schema of :Related issues