Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(showcase): use marked and prismjs to highlight the code #2436

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fpaul-1A
Copy link
Contributor

@fpaul-1A fpaul-1A commented Nov 8, 2024

Proposed change

Following #2414
Replace all usage of highlight.js to prismjs

Related issues

- No issue associated -

@fpaul-1A fpaul-1A requested a review from a team as a code owner November 8, 2024 17:36
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.84%. Comparing base (bbc4f26) to head (a1c247b).
Report is 11 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fpaul-1A fpaul-1A force-pushed the feat/showcase-prism branch 2 times, most recently from 219c074 to 7b7eb1d Compare November 12, 2024 10:35
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligned the theme would be nice, they do not have css var that we can map to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are lots of themes we can choose from
I picked this theme to match the one we use in the training (as much as possible, prismjs uses regexes not actual grammar)

@fpaul-1A fpaul-1A force-pushed the feat/showcase-prism branch 2 times, most recently from acc9d88 to cf19c15 Compare November 14, 2024 11:02
sdo-1A
sdo-1A previously approved these changes Nov 20, 2024
@@ -222,6 +222,7 @@
"bootstrap": "5.3.3",
"bootstrap-icons": "^1.11.3",
"browserslist": "^4.21.4",
"clipboard": "^2.0.11",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it (with prism deps) required at root level dependency?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test without it but I believe we have to put all the deps at root level for the angular build

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But they are integrated as script and not angular component, so not sure :S

apps/showcase/src/app/sdk/sdk.template.html Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants