-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(showcase): use marked and prismjs to highlight the code #2436
base: main
Are you sure you want to change the base?
Conversation
84f226e
to
c055f7e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files☔ View full report in Codecov by Sentry. |
219c074
to
7b7eb1d
Compare
apps/showcase/e2e-playwright/sanity/screenshots/visual-sanity.e2e.ts/chromium/localization.png
Outdated
Show resolved
Hide resolved
...showcase/e2e-playwright/sanity/screenshots/visual-sanity.e2e.ts/chromium/dynamic-content.png
Outdated
Show resolved
Hide resolved
7b7eb1d
to
2968f35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aligned the theme would be nice, they do not have css var that we can map to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are lots of themes we can choose from
I picked this theme to match the one we use in the training (as much as possible, prismjs uses regexes not actual grammar)
acc9d88
to
cf19c15
Compare
cf19c15
to
4bc6de7
Compare
9453462
to
e8a280c
Compare
@@ -222,6 +222,7 @@ | |||
"bootstrap": "5.3.3", | |||
"bootstrap-icons": "^1.11.3", | |||
"browserslist": "^4.21.4", | |||
"clipboard": "^2.0.11", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it (with prism
deps) required at root level dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't test without it but I believe we have to put all the deps at root level for the angular build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But they are integrated as script and not angular component, so not sure :S
e8a280c
to
a1c247b
Compare
Proposed change
Following #2414
Replace all usage of
highlight.js
toprismjs
Related issues
- No issue associated -