Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT REVIEW] Migrate to eslint 9 and flat config #2192

Draft
wants to merge 127 commits into
base: main
Choose a base branch
from

Commits on Sep 23, 2024

  1. Configuration menu
    Copy the full SHA
    c75ab9f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    82d6fa4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a74c4ea View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1f1e35c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ccd0794 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b16511c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8c6621d View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. feat(eslint): select @o3r/eslint-config or @o3r/eslint-config-otter d…

    …epending on the presence of eslintrc or not
    matthieu-crouzet committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    f38568f View commit details
    Browse the repository at this point in the history
  2. feat(eslint): select @o3r/eslint-config or @o3r/eslint-config-otter d…

    …epending on the presence of eslintrc or not (#2193)
    
    ## Proposed change
    
    - Select `@o3r/eslint-config` or `@o3r/eslint-config-otter` depending on
    the presence of eslintrc or not
    - Use `@o3r/eslint-config` when generating a shell sdk
    matthieu-crouzet authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    54fcd3f View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Configuration menu
    Copy the full SHA
    85ab18b View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. fix(eslint): set relative path instead of absolute path in the merge …

    …config (#2201)
    
    ## Proposed change
    
    Set relative path instead of absolute path in the merge config
    matthieu-crouzet authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    0b4c04e View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Configuration menu
    Copy the full SHA
    b5ebbf5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0f58397 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0680498 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Configuration menu
    Copy the full SHA
    6af49f2 View commit details
    Browse the repository at this point in the history
  2. feat(eslint): change all warnings into errors (#2269)

    ## Proposed change
    As discussed move all warnings into errors.
    Open to discussion if some rules should become `off` instead of `errors`
    matthieu-crouzet authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    5c066b9 View commit details
    Browse the repository at this point in the history
  3. feat(eslint): one import per line + import alphabetize + export all a…

    …lphabetize (#2273)
    
    ## Proposed change
    One import per line
    Import alphabetize
    Export all alphabetize
    matthieu-crouzet authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    e0dd9f4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    566a8a1 View commit details
    Browse the repository at this point in the history
  5. feat(eslint): require a description when using eslint disable directi…

    …ve (#2274)
    
    ## Proposed change
    Require a description when using eslint disable directive
    matthieu-crouzet authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    5fb1eba View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Configuration menu
    Copy the full SHA
    3a3aac3 View commit details
    Browse the repository at this point in the history
  2. feat(eslint): change default vscode config (#2276)

    ## Proposed change
    Change default vscode config
    matthieu-crouzet authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    ba583d7 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Configuration menu
    Copy the full SHA
    a7fe98e View commit details
    Browse the repository at this point in the history
  2. docs(eslint): update documentation for eslint flat config (#2196)

    ## Proposed change
    
    Update documentation for eslint flat config
    
    - [x] Review the ESLint configuration with the team
    matthieu-crouzet authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    b02e518 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Configuration menu
    Copy the full SHA
    8447fb6 View commit details
    Browse the repository at this point in the history
  2. chore: apply auto fix

    kpanot committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    c14865c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3dc1d91 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1f473b0 View commit details
    Browse the repository at this point in the history
  5. fix(eslint): run the auto-fix with the new config (#2291)

    ## Proposed change
    Run the auto-fix with the new config
    
    ## Rules to discuss
    
    - [x]
    [@eslint-community/eslint-comments/disable-enable-pair](https://github.com/mysticatea/eslint-plugin-eslint-comments/blob/master/docs/rules/disable-enable-pair.md)
    => off
    - [x]
    [unicorn/prefer-type-error](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-type-error.md)
    => off
    - [x]
    [unicorn/numeric-separators-style](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/numeric-separators-style.md)
    => keep
    - [x]
    [unicorn/no-useless-promise-resolve-reject](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-useless-promise-resolve-reject.md)
    => off
    - [x]
    [@stylistic/operator-linebreak](https://eslint.style/rules/js/operator-linebreak)
    `"before", { "overrides": { "=": "after"} }`
    - [x]
    [unicorn/no-useless-undefined](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-useless-undefined.md)
    => keep until issue with mandatory params
    - [x]
    [unicorn/prefer-set-has](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-set-has.md)
    => off
    - [x]
    [@stylistic/arrow-parens](https://eslint.style/rules/js/arrow-parens) =>
    keep
    - [x]
    [unicorn/prefer-prototype-methods](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-prototype-methods.md)
    => keep
    - [x]
    [unicorn/prefer-string-slice](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-string-slice.md)
    => off
    
    ## Missing rules
    - [ ] [max-len](https://eslint.org/docs/latest/rules/max-len)
    - [x]
    [require-await](https://eslint.org/docs/latest/rules/require-await)
    kpanot authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    3f31086 View commit details
    Browse the repository at this point in the history
  6. Fix/eslint auto fix suite (#2304)

    ## Proposed change
    
    Apply eslint auto-run (remaining rules on import).
    
    removed rule override:
    ```
          'import/first': 'off',
          'import/order': 'off',
          'import/newline-after-import': 'off',
          'import-newlines/enforce': 'off',
          '@stylistic/object-curly-spacing': 'off',
          '@stylistic/no-multiple-empty-lines': 'off',
          '@stylistic/brace-style': 'off',
          '@stylistic/padded-blocks': 'off',
          '@stylistic/block-spacing': 'off',
          '@stylistic/template-curly-spacing': 'off'
    ```
    
    Require to merge #2291
    kpanot authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    c8dca7c View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Configuration menu
    Copy the full SHA
    925a510 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a935e28 View commit details
    Browse the repository at this point in the history
  3. Fix/eslint regexp (#2305)

    Apply of the RegExp Rules
    
    Require #2304 to be merged before review
    kpanot authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    c7f4727 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7144c91 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    274293d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6bf9c4d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    887214b View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Fix eslint issue on chrome devtools (#2316)

    ## Proposed change
    Fix eslint issue on chrome devtools
    matthieu-crouzet authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    5c37aa9 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Configuration menu
    Copy the full SHA
    9b60b9c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3c3f0e8 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Configuration menu
    Copy the full SHA
    a7fa378 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2dee633 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a5232d9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ecb6913 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7653092 View commit details
    Browse the repository at this point in the history
  6. fix: eslint configuration for windows (#2339)

    ## Proposed change
    
    Fix configuration of eslint to work for windows environment (absolute
    file paths and quotes in nx.json)
    
    ## Related issues
    
    - 🐛 Fixes #(issue)
    - 🚀 Feature #(issue)
    
    <!-- Please make sure to follow the contributing guidelines on
    https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md -->
    matthieu-crouzet authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    e9fd8ac View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    876e3e6 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Configuration menu
    Copy the full SHA
    48d5617 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5f32df4 View commit details
    Browse the repository at this point in the history
  3. fix(eslint): manual fix of eslint errors on ama-sdk (#2330)

    all clients packages are not handled here because not present since the
    rebase has not been done since a while
    matthieu-crouzet authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    d8d7c81 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b0ae531 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    09207c4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a7d24ec View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Configuration menu
    Copy the full SHA
    f4ae5e4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6504113 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Configuration menu
    Copy the full SHA
    60aa35c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    897e97a View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Configuration menu
    Copy the full SHA
    202723b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a5bc74c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fccdec8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e14b319 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bc41ec4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e134f5c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    bafa019 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0e38099 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    7ccfa2b View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    0c01f91 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    6987d56 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    0535406 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    3cde0b7 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    d94c310 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    7dc9a4f View commit details
    Browse the repository at this point in the history
  16. fix: manual fix of eslint errors on packages @o3r/{a}* (#2341)

    ## Proposed change
    
    Manual fix of ESLint errors for @o3r/analytics, @o3r/apis-manager,
    @o3r/application, @o3r/artifactory-tools, @o3r/azure-tools
    
    ## Related issues
    
    - 🐛 Fixes #(issue)
    - 🚀 Feature #(issue)
    
    <!-- Please make sure to follow the contributing guidelines on
    https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md -->
    matthieu-crouzet authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    892a0a6 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Configuration menu
    Copy the full SHA
    613118d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0e8fde5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    22097b3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b3a057e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b42cb63 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    903e88e View commit details
    Browse the repository at this point in the history
  7. fix: automatic and manual fixes of eslint errors on rules engine (#2366)

    ## Proposed change
    
    Manual fix of ESLint errors for @o3r/rules-engine
    
    ## Related issues
    
    <!--
    Please make sure to follow the [contribution
    guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md)
    -->
    
    *- No issue associated -*
    
    <!-- * 🐛 Fix #issue -->
    <!-- * 🐛 Fix resolves #issue -->
    <!-- * 🚀 Feature #issue -->
    <!-- * 🚀 Feature resolves #issue -->
    <!-- * :octocat: Pull Request #issue -->
    matthieu-crouzet authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    ebecaff View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b67b2fe View commit details
    Browse the repository at this point in the history
  9. fix: manual fix of eslint errors on packages @o3r/{d,e,f}* (#2359)

    ## Proposed change
    
    Manual fix of ESLint errors for @o3r/design, @o3r/dev-tools,
    @o3r/dynamic-content, @o3r/eslint-config, @o3r/eslint-config-otter,
    @o3r/extractors, @o3r/forms
    
    ## Related issues
    
    - 🐛 Fixes #(issue)
    - 🚀 Feature #(issue)
    
    <!-- Please make sure to follow the contributing guidelines on
    https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md -->
    matthieu-crouzet authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    ec030da View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Configuration menu
    Copy the full SHA
    ee8ba8c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4ea7e8f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e5d78e1 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Configuration menu
    Copy the full SHA
    29ef61f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d3c4e8f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    eae99fb View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Configuration menu
    Copy the full SHA
    43d3e3f View commit details
    Browse the repository at this point in the history
  2. fix(eslint): fix remaining eslint issue after config changes (#2407)

    Next steps after this PR
    - [ ] Rebase with main
    - [ ] Migrate new packages (pipeline, clients, training-tools, ...)
    matthieu-crouzet authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    11c40fd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dbaade8 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Configuration menu
    Copy the full SHA
    15b2ae7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    15bdc00 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    71e0994 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2ec84c6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ada814d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b1fb980 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d8f534b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4caa751 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    67119ae View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    076ef25 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    d5f87f2 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    fa913a6 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    1416271 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    59694d8 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Configuration menu
    Copy the full SHA
    f430b39 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a651437 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8e2f59f View commit details
    Browse the repository at this point in the history
  4. docs(eslint): stylistic difference with eslintrc (#2432)

    ## Proposed change
    
    <!--
    Please include a summary of the changes and the related issue.
    Please also include relevant motivation and context.
    -->
    
    ## Related issues
    
    <!--
    Please make sure to follow the [contribution
    guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md)
    -->
    
    *- No issue associated -*
    
    <!-- * 🐛 Fix #issue -->
    <!-- * 🐛 Fix resolves #issue -->
    <!-- * 🚀 Feature #issue -->
    <!-- * 🚀 Feature resolves #issue -->
    <!-- * :octocat: Pull Request #issue -->
    matthieu-crouzet authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    b92003f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bb11321 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Configuration menu
    Copy the full SHA
    093d50d View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Configuration menu
    Copy the full SHA
    68bc538 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ada2533 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. Configuration menu
    Copy the full SHA
    998064b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0003ee8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4363b59 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8399ca1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    cce253b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    cb3ab69 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    368ba98 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f3ff1a3 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    0434646 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    433f3b7 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    cd54143 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Configuration menu
    Copy the full SHA
    c701a9a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    31fe7c0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c094e38 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c5f2d9f View commit details
    Browse the repository at this point in the history