fix ERR_HTTP2_HEADER_SINGLE_VALUE error #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divdavem
force-pushed
the
http2HeaderSingleValue
branch
from
f7ee615 to
ecc82c0
Compare
divdavem
force-pushed
the
http2HeaderSingleValue
branch
from
ecc82c0 to
c365126
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #494 +/- ##
==========================================
+ Coverage 91.64% 91.68% +0.03%
==========================================
Files 36 36
Lines 1209 1214 +5
Branches 273 274 +1
==========================================
+ Hits 1108 1113 +5
Misses 50 50
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@fbasso Thank you for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issue: if http 2 is enabled in kassette, and if the remote server, speaking only http 1, returns multiple values for a header that, according to http 2, is only allowed a single value (such as
x-content-type-options), the ERR_HTTP2_HEADER_SINGLE_VALUE error was thrown because kassette was trying to keep all header values when replying to the browser with http 2.The fix prevents the error by only keeping the first value in this case.