fix: allow connection to legacy unsafe servers #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #484 +/- ##
=======================================
Coverage 91.52% 91.52%
=======================================
Files 36 36
Lines 1192 1192
Branches 268 268
=======================================
Hits 1091 1091
Misses 50 50
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
divdavem
force-pushed
the
legacyServers
branch
from
7f80e90
to
b5a3d37
Compare
This commit adds the SSL_OP_LEGACY_SERVER_CONNECT flag when connecting to legacy remote servers for increased compatibility. Note that it allows man-in-the-middle attacks, but those attacks are already possible anyway because of the rejectUnauthorized option which allows any certificate on the server. kassette is a test tool that is not designed to run in a production environment. This PR fixes the following error that can happen when this flag is not set: 78250000:error:0A000152:SSL routines:final_renegotiate:unsafe legacy renegotiation disabled
divdavem
force-pushed
the
legacyServers
branch
from
b5a3d37
to
256b7d9
Compare
divdavem
changed the title
|
@fbasso Thank you for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
SSL_OP_LEGACY_SERVER_CONNECTflag when connecting to legacy remote servers for increased compatibility.Note that it allows man-in-the-middle attacks, but those attacks are already possible anyway because of the
rejectUnauthorizedoption which allows any certificate on the server.kassetteis a test tool that is not designed to run in a production environment.This PR fixes the following error that can happen when this flag is not set: