fix: allow connection to legacy unsafe servers #484
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
SSL_OP_LEGACY_SERVER_CONNECT
flag when connecting to legacy remote servers for increased compatibility.Note that it allows man-in-the-middle attacks, but those attacks are already possible anyway because of the
rejectUnauthorized
option which allows any certificate on the server.kassette
is a test tool that is not designed to run in a production environment.This PR fixes the following error that can happen when this flag is not set: