Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconcile the pyrra generated prometheusrule crs with azure prometheusrulegroups resources #1110
base: main
Are you sure you want to change the base?
Reconcile the pyrra generated prometheusrule crs with azure prometheusrulegroups resources #1110
Changes from 12 commits
c87a612
63151d5
7728238
28396c7
10e8438
f3f6f2d
a1d5ee2
13fea12
fa10f01
afd7fd8
48db0e5
e0cf42a
50b824f
f138a09
04aac84
da40ae5
bd48b3b
0e3a647
1a2baa2
730858b
ff46f57
a1377b7
c0066c9
3227610
6a25df2
c325b96
257877f
fd2b33c
ad2cf3c
d164a3b
b83adad
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT
Probably generated code, the check
.Values.certmanager.enable
seems unnecessary as the outer most if already has checked that it is trueThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generated code indeed.
One of the {{end}} blocks should be further up.