Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bruno test and fix max limit in revoke all #157

Merged
merged 6 commits into from
Dec 11, 2024

Conversation

lovoll
Copy link
Contributor

@lovoll lovoll commented Dec 9, 2024

Description

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

}

tests {
test("post InstanceDelegation ReadSign", function() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alle testene har nå det samme navnet: "post InstanceDelegation ReadSign"
som gjør det vanskelig å finne tilbake til hvilken request som evt. feiler.

Jeg har begynt å sette request navnet i en variabel i starten som jeg så bruker som test-navnet (i mangel på å finne en lett måte å bare kunne hentet .bru filnavnet direkte). Evt. kan man da også ha flere test funksjoner for samme request og bruke noa ala requestName +"|" + testName

F.eks:

// Should be the same as the .bru request file. Used as prefix in test name which also shows in test result in pipeline.
const requestName = "InstDelg_DelgChk_AppWithDelegableRights_Ok";
const data = res.getBody().data;

test(requestName, function() {
  expect(res.status).to.equal(200);
});

…e assert instead of axpect

Revrote all test testing multiple iterations of delegations to use for loop
Revrote al test to expect to to be in alist to not be vulnerable to difrent sorting from server and not using sorting on client as this would only fix it for one environment but could be difrent in other environment based on the uuid of that user.
… will make the number of policies handled not ResourceId
@lovoll lovoll merged commit b28dc08 into main Dec 11, 2024
14 checks passed
@lovoll lovoll deleted the feature/638-AddBrunoTestAndFixMaxLimitInRevokeAll branch December 11, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants