Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OverviewPage with new Design of 24.11.23 #129

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

Torgeir333
Copy link
Contributor

Description

The superficial changes of the New Design of 24.11.23
have been implemented for OverviewPage.

Note that the new Design implies a long list of changes
both to Frontend (see issue #126, and Task list therein ),
and to BFF and deeper Backend (issue pending).

Also note that some of the changes in the New Design seems
to ignore much of the work done this autumn in Frontend and BFF with
regard to DTO objects and fields therein (see issue #8 ).

A case in point are the remaining title and sub-tile the SystemUser list,
"System Lakeslus Rapportering" and "Aqua Power". It is now unclear what fields
in the DTO these titles refer to.

Thus in the next iteration these caveats should be addressed.
Preferably the New Design should be clarified in issue #8 .

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated in the Repo Wiki

Copy link
Contributor

@simen-rekkedal simen-rekkedal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@Torgeir333 Torgeir333 merged commit 3b53913 into main Dec 5, 2023
@Torgeir333 Torgeir333 deleted the overviewpage31 branch December 5, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants