Clarify permissions requirements earlier in the documentation #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoralCode
reviewed
Oct 8, 2024
|
Were you using an automatic tool to apply the markdownlint rules for this PR? if so it may be cool to set up this tool to run as a CI job to keep the docs to that standard in the future (in a separate PR though) |
MoralCode
changed the title
No i didn't, i use markdownlints extension in vscode. But i guess it's cool idea to do so. And but again there are risk to use automation implement rules such as remove unwanted doc, i guess maybe we can discuss it in an issue for later. |
BWMuller
pushed a commit
to BWMuller/background_location
that referenced
this pull request
Oct 13, 2024
…lim#226) * Improve documentation * Fix typos * Improve explanation * Add note for applying permission to info.plist * Change flutter package get to flutter pub get * Add placeholder and caution to add description in ios config * Fix some typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #225
What i have changed in
README.md:BackgroundLocation.startLocationService();sectiongetLocationUpdatessectionReference for markdown format Markdownlints Rules