-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inherit host's proxy env vars in generated containers #99
Conversation
yum.conf is a symlink to dnf.conf in el8+ but `follow: false` (default) does not follow the symlink and creates yum.conf as a normal file.
In Docker CLI, you can configure proxy settings for generated containers by setting up ~/.docker/config.json. However, Docker provider in Terraform does not read this file, so proxy env vars need to be specified directory.
I forgot to mention this, but is this line necessary? alts/resources/docker/docker.tf.tmpl Line 14 in 79654d5
I don't think it's a good idea to force specific DNS servers and build.almalinux.org doesn't seem to use it. |
@pastalian it was the most reliable way to have domain name resolution because sometimes local configuration interferes with it. If you think it's safe to remove it - we can, however I'd like to double check that it will be working in all cases |
Code Coverage Summary
Linter reportsPylint report
Black report
Isort report
Bandit report
View full reports on the Job Summary page. |
I see. Then I'll leave it as is for now. I can simply remove it on my dev machine. |
In Docker CLI, you can configure proxy settings for generated containers
by setting up ~/.docker/config.json. However, Docker provider in
Terraform does not read this file, so proxy env vars need to be
specified directory.
Resolves: AlmaLinux/build-system#321