Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added FIPS blog post #623

Merged
merged 16 commits into from
Oct 7, 2024
Merged

Added FIPS blog post #623

merged 16 commits into from
Oct 7, 2024

Conversation

Noam-Alum
Copy link
Contributor

Added FIPS blog post.

@bennyvasquez, if you can create one of those AlmaLinux images for the thumbnail that would be great 😁.

e.g.

image

Huge thanks to Simon John for helping me on this one.

bennyvasquez
bennyvasquez reviewed Sep 11, 2024
View reviewed changes
Copy link
Member

@bennyvasquez bennyvasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, Noam! Well done to you, friend. I can definitely make another header image, and I've got a few suggestions/adjustments. Take a look at those, I'll get a header image made, and then we'll get it scheduled!

content/blog/2024-09-09-fips-validation-for-almalinux-update.md Outdated Show resolved Hide resolved
content/blog/2024-09-09-fips-validation-for-almalinux-update.md Outdated Show resolved Hide resolved
content/blog/2024-09-09-fips-validation-for-almalinux-update.md Outdated Show resolved Hide resolved
content/blog/2024-09-09-fips-validation-for-almalinux-update.md Outdated Show resolved Hide resolved
@bennyvasquez bennyvasquez added the blog post blog post label Sep 11, 2024
@Noam-Alum
Copy link
Contributor Author

The mailing list is already at the footer (I'm guessing it's the newsletter) so I added just the link to the security chat but I think it's enough.

@sej7278
Copy link
Contributor

sej7278 commented Sep 14, 2024

Looks good to me, LGTM!

@sej7278
Copy link
Contributor

sej7278 commented Sep 23, 2024

I tried to find the cover image template but couldn't, I thought there was one here somewhere that we could just put some text over

bennyvasquez
bennyvasquez reviewed Sep 23, 2024
View reviewed changes
Copy link
Member

@bennyvasquez bennyvasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more changes, and then I'm ready to schedule this for Wednesday morning! I've attached a header image here that you'll need to update your PR with, after you incorporate the changes here. Please name the file "fipsupdate.png" when you move it to the static folder.
fipsupdate

content/blog/2024-09-09-fips-validation-for-almalinux-update.md Outdated Show resolved Hide resolved
content/blog/2024-09-09-fips-validation-for-almalinux-update.md Outdated Show resolved Hide resolved
content/blog/2024-09-09-fips-validation-for-almalinux-update.md Outdated Show resolved Hide resolved
content/blog/2024-09-09-fips-validation-for-almalinux-update.md Outdated Show resolved Hide resolved
content/blog/2024-09-09-fips-validation-for-almalinux-update.md Outdated Show resolved Hide resolved
content/blog/2024-09-09-fips-validation-for-almalinux-update.md Outdated Show resolved Hide resolved
@Noam-Alum
Copy link
Contributor Author

Noam-Alum commented Sep 25, 2024 •
edited
Loading

Just to clarify @bennyvasquez do you need @Noam-Alum to make these changes for tomorrow, or are you doing/done them?

Sorry for doing this so close to release day, I'll send a PR with the thumbnail image in half an hour 😄.

@bennyvasquez
Copy link
Member

Sorry for missing your reply here, @Noam-Alum! I'll publish this Monday morning.

@bennyvasquez
Update and rename 2024-09-09-fips-validation-for-almalinux-update.md …
2d53877 
…to 2024-10-07-fips-validation-for-almalinux-update.md
@Noam-Alum
Copy link
Contributor Author

Sorry for missing your reply here, @Noam-Alum! I'll publish this Monday morning.

Great 😁.

@bennyvasquez bennyvasquez added the Staged This PR is approved and will merged at the appropriate time label Oct 4, 2024
@bennyvasquez
Copy link
Member

@Noam-Alum can you try re-basing this PR against master and pushing that up here, to see if that resolves the build problems? It looks like a problem with the blog posts frontmatter somehow, but it builds locally just fine for me.

@Noam-Alum
Copy link
Contributor Author

@Noam-Alum can you try re-basing this PR against master and pushing that up here, to see if that resolves the build problems? It looks like a problem with the blog posts frontmatter somehow, but it builds locally just fine for me.

Did I do it correctly? Let me know.

@bennyvasquez
Copy link
Member

it looks to me like you did, but the publish error was persisting. I was able to get it to reproduce locally by upgrading from Hugo 0.134.1 -> 0.135.0, and fixed it in #654, but then I saw these:

ERROR deprecated: .Page.PrevPage was deprecated in Hugo v0.123.0 and will be removed in Hugo 0.136.0. Use .Page.Prev instead.
ERROR deprecated: .Page.NextPage was deprecated in Hugo v0.123.0 and will be removed in Hugo 0.136.0. Use .Page.Next instead.

Those will be resolved after we get #648 merged in. @Noam-Alum can you look at the questions in that PR? Once that's done, this one will need to be re-based, and then we'll be good to go.

@Noam-Alum
Copy link
Contributor Author

Noam-Alum commented Oct 5, 2024 •
edited
Loading

it looks to me like you did, but the publish error was persisting. I was able to get it to reproduce locally by upgrading from Hugo 0.134.1 -> 0.135.0, and fixed it in #654, but then I saw these:

ERROR deprecated: .Page.PrevPage was deprecated in Hugo v0.123.0 and will be removed in Hugo 0.136.0. Use .Page.Prev instead.
ERROR deprecated: .Page.NextPage was deprecated in Hugo v0.123.0 and will be removed in Hugo 0.136.0. Use .Page.Next instead.

Those will be resolved after we get #648 merged in. @Noam-Alum can you look at the questions in that PR? Once that's done, this one will need to be re-based, and then we'll be good to go.

Done, sorry for being so late for this, I forgot about that question 🙃.

You can always ping me on Mattermost in cases like this, I tend to forget about things when there's too much going on in my life 😁.

@bennyvasquez
Copy link
Member

bennyvasquez commented Oct 5, 2024 •
edited
Loading

k, now that #648 is merged in, please rebase this one against master again and we should be good to go.

@Noam-Alum can your re-base this on master one more time, please?

@sej7278
Copy link
Contributor

sej7278 commented Oct 6, 2024 •
edited
Loading

The OpenSSL module moved today from "Coordination" to "Finalization" so that cert should be due this week too:

https://csrc.nist.gov/Projects/cryptographic-module-validation-program/modules-in-process/modules-in-process-list

I'll give you a shout if it arrives before you push the button tomorrow @bennyvasquez

@bennyvasquez
Copy link
Member

YAY! IT BUILT! https://35af5307.almalinux-org.pages.dev/blog/2024-10-07-fips-validation-for-almalinux-update/

@bennyvasquez bennyvasquez merged commit 41a1f31 into AlmaLinux:master Oct 7, 2024
2 checks passed
@Noam-Alum
Copy link
Contributor Author

YAY! IT BUILT! https://35af5307.almalinux-org.pages.dev/blog/2024-10-07-fips-validation-for-almalinux-update/

Finally 😄, that's awesome!

@Noam-Alum Noam-Alum deleted the Add_FIPS_blog_post branch October 7, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sej7278 sej7278 sej7278 left review comments

@bennyvasquez bennyvasquez bennyvasquez approved these changes

Assignees
No one assigned
Labels
blog post blog post Staged This PR is approved and will merged at the appropriate time
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Noam-Alum @sej7278 @bennyvasquez