-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add AMD 4004 series certification page #582
Conversation
Please do not merge. |
a36043a
to
0e545e0
Compare
0e545e0
to
08d0261
Compare
08d0261
to
b00531c
Compare
b00531c
to
04a982f
Compare
04a982f
to
3c6422b
Compare
3c6422b
to
d333fbd
Compare
d333fbd
to
146fd8c
Compare
146fd8c
to
19b01a3
Compare
19b01a3
to
75006ce
Compare
75006ce
to
5e692f9
Compare
This is ready to go! |
@mattlasheboro Mind glancing over this to see if there is going to be any weird display issues (that are obvious)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Added two commas.
I'd wait for Matt to verify that it displays okay across devices before merging, though.
"processor series": "processor series", | ||
"Motherboard": "Motherboard", | ||
"tests cover benchmarking of OS features. The result of benchmarking can be found in the PDF linked above.": "tests cover benchmarking of OS features. The result of benchmarking can be found in the PDF linked above.", | ||
"The conducted tests ensure that AMD EPYC™ 4004 series CPUs and, generally for any servers based on EPYC processors, AlmaLinux OS works properly guaranteeing stability, security, and high performance.": "The conducted tests ensure that AMD EPYC™ 4004 series CPUs and, generally for any servers based on EPYC processors, AlmaLinux OS works properly guaranteeing stability, security, and high performance." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added missing commas
The conducted tests ensure that AMD EPYC™ 4004 series CPUs and, generally, for any servers based on EPYC processors, AlmaLinux OS works properly, guaranteeing stability, security, and high performance.
There are some issues on small displays. I can send over some fixes tonight if this can wait. |
Have you had a chance to poke at this yet? |
I need to get this merged. I still welcome the fixes you mentioned when you get a chance to work on them. |
Sounds good, the only important change was the one suggested above that fixed the button being broke on mobile. Everything else is purely aesthetic. |
No description provided.