Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add AMD 4004 series certification page #582

Merged
merged 1 commit into from
Jul 1, 2024
Merged

add AMD 4004 series certification page #582

merged 1 commit into from
Jul 1, 2024

Conversation

jonathanspw
Copy link
Member

No description provided.

@jonathanspw
Copy link
Member Author

Please do not merge.

@jonathanspw jonathanspw marked this pull request as draft June 12, 2024 19:33
@jonathanspw jonathanspw marked this pull request as ready for review June 12, 2024 19:33
@jonathanspw jonathanspw marked this pull request as draft June 18, 2024 15:29
@jonathanspw jonathanspw marked this pull request as ready for review June 24, 2024 13:57
@jonathanspw
Copy link
Member Author

This is ready to go!

@jonathanspw
Copy link
Member Author

Preview URL: https://29dfabca.almalinux-org.pages.dev/amd-epyc-june2024/

@codyro
Copy link
Member

codyro commented Jun 24, 2024

@mattlasheboro Mind glancing over this to see if there is going to be any weird display issues (that are obvious)?

codyro
codyro approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@codyro codyro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Added two commas.

I'd wait for Matt to verify that it displays okay across devices before merging, though.

i18n/en.json
"processor series": "processor series",
"Motherboard": "Motherboard",
"tests cover benchmarking of OS features. The result of benchmarking can be found in the PDF linked above.": "tests cover benchmarking of OS features. The result of benchmarking can be found in the PDF linked above.",
"The conducted tests ensure that AMD EPYC™ 4004 series CPUs and, generally for any servers based on EPYC processors, AlmaLinux OS works properly guaranteeing stability, security, and high performance.": "The conducted tests ensure that AMD EPYC™ 4004 series CPUs and, generally for any servers based on EPYC processors, AlmaLinux OS works properly guaranteeing stability, security, and high performance."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added missing commas

The conducted tests ensure that AMD EPYC™ 4004 series CPUs and, generally, for any servers based on EPYC processors, AlmaLinux OS works properly, guaranteeing stability, security, and high performance.

@mattrandomnumber
Copy link
Contributor

@mattlasheboro Mind glancing over this to see if there is going to be any weird display issues (that are obvious)?

There are some issues on small displays. I can send over some fixes tonight if this can wait.

@jonathanspw
Copy link
Member Author

@mattlasheboro Mind glancing over this to see if there is going to be any weird display issues (that are obvious)?

There are some issues on small displays. I can send over some fixes tonight if this can wait.

Have you had a chance to poke at this yet?

@jonathanspw
Copy link
Member Author

I need to get this merged. I still welcome the fixes you mentioned when you get a chance to work on them.

@jonathanspw jonathanspw merged commit 2be9999 into AlmaLinux:master Jul 1, 2024
2 checks passed
@mattrandomnumber
Copy link
Contributor

I need to get this merged. I still welcome the fixes you mentioned when you get a chance to work on them.

Sounds good, the only important change was the one suggested above that fixed the button being broke on mobile. Everything else is purely aesthetic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyro codyro codyro approved these changes

@bennyvasquez bennyvasquez Awaiting requested review from bennyvasquez

@iseletsk iseletsk Awaiting requested review from iseletsk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathanspw @codyro @mattrandomnumber