Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds TuxCare and OpenLogic blurbs #276

Merged
merged 3 commits into from
Jul 28, 2023
Merged

Adds TuxCare and OpenLogic blurbs #276

merged 3 commits into from
Jul 28, 2023

Conversation

mattrandomnumber
Copy link
Contributor

Based on issue:

#105

@mattrandomnumber
Copy link
Contributor Author

How it appears on small screens:
commercial-support-small-displays

How it appears on larger screens:
commercial-support-large-displays

@bennyvasquez
Copy link
Member

@mattlasheboro this'll be perfect! But in the code can you add sort of delineators between the sections? That'll help future editing, and making sure that all of the sections have the right content.

layouts/index.html Outdated Show resolved Hide resolved
@mattrandomnumber
Copy link
Contributor Author

mattrandomnumber commented Jul 25, 2023

@bennyvasquez Good idea, I added some spacing and a comment to try and increase the readability a bit.

The indentation is a bit wonky overall, some places use tabs and some use spaces but I believe I got everything lined up correctly.

I also removed the empty class attributes that I inadvertently left on the P elements.

@codyro
Copy link
Member

codyro commented Jul 25, 2023

The indentation is a bit wonky overall, some places use tabs and some use spaces but I believe I got everything lined up correctly.

The whole code base needs to go through a linter and then add it to our CI workflow for PR's. It's on the to do list :)

layouts/index.html Outdated Show resolved Hide resolved
layouts/index.html Outdated Show resolved Hide resolved
@bennyvasquez
Copy link
Member

@mattlasheboro as long as you're okay with my adjustments, you can commit them in and then we'll do one final check to make sure it looks good before merging!

@mattrandomnumber mattrandomnumber temporarily deployed to external July 28, 2023 14:44 — with GitHub Actions Inactive
@mattrandomnumber
Copy link
Contributor Author

I believe everything is right now? I also changed the link for Cybertrust because it seemed incorrect, but if I made a mistake there let me know and I'll swap it back.

@bennyvasquez bennyvasquez merged commit efd14ac into AlmaLinux:master Jul 28, 2023
2 checks passed
@bennyvasquez
Copy link
Member

Looks good to me. Thank you, @mattlasheboro! This is awesome.

@mattrandomnumber
Copy link
Contributor Author

Great, thank you! I'm happy to help how I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants