[DRAFT] Fix some incomplete metadata issue partially #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch allows users to create a package SBOM by specifying the RPM package itself without having to calculate a hash value. This also allows the SBOM field to be extended since the package information can be referenced within alma_sbom.
|
From the issue #48 , I discovered a difference in NEVRA processing when api_ver == '0.1'. |
KAWAHARA-souta
changed the title
When data cannot be retrieved from immudb, or when data for package is missing, if the --rpm-package option was used to specify an rpm package, I made it so that the rpm package is used to supplement the information. The following issues have been partially fixed. - AlmaLinux#42 - AlmaLinux#44 And the following issues have been fixed. - AlmaLinux#26
Apply common.check_required_data for _add_package_source_info() and _add_package_build_info(). This patch fixes the following issues. - AlmaLinux#47
KAWAHARA-souta
force-pushed
the
fix_sbom_metadata_error
branch
from
576b5ca
to
9a863f7
Compare
…tual value. This patch fixes AlmaLinux#48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When data cannot be retrieved from immudb, or when data for package is
missing, if the --rpm-package option was used to specify an rpm package,
I made it so that the rpm package is used to supplement the information.
The following issues have been partially fixed.
And the following issues have been fixed.
Note1:
This MR nees to merge #39 .
Please merge that MR first.
Note2:
This MR may conflict with other MRs.
(At least, it will definitely conflict with #45.)
I will resolve the conflicts after #45 is merged, so please let me know when that happens.
Also, alma_sbom.py has become bloated, and there have been many conflicts in the past. We may need to reconsider its structure.