-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Normalize whitespace when comparing patch context lines #6541
Open
neubig
wants to merge
1
commit into
main
Choose a base branch
from
fix/patch-whitespace-handling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+90
−6
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,79 @@ | ||||||
from openhands.resolver.patching.apply import apply_diff | ||||||
from openhands.resolver.patching.patch import parse_patch | ||||||
|
||||||
|
||||||
def test_patch_whitespace_mismatch(): | ||||||
"""Test that the patch application fails correctly when whitespace doesn't match.""" | ||||||
# Original content has a line with spaces | ||||||
original_content = """class Example: | ||||||
def method(self): | ||||||
pass | ||||||
|
||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think you mean by
Suggested change
otherwise this test won't pass |
||||||
def another(self): | ||||||
pass""" | ||||||
|
||||||
# Patch expects an empty line (no spaces) | ||||||
patch_text = """diff --git a/example.py b/example.py | ||||||
index 1234567..89abcdef 100644 | ||||||
--- a/example.py | ||||||
+++ b/example.py | ||||||
@@ -2,6 +2,10 @@ class Example: | ||||||
def method(self): | ||||||
pass | ||||||
|
||||||
+ new_field: str = "value" | ||||||
+ | ||||||
def another(self): | ||||||
pass""" | ||||||
|
||||||
patch = next(parse_patch(patch_text)) | ||||||
# The patch should still work because we normalize whitespace | ||||||
new_content = apply_diff(patch, original_content) | ||||||
assert new_content == [ | ||||||
'class Example:', | ||||||
' def method(self):', | ||||||
' pass', | ||||||
' ', | ||||||
' new_field: str = "value"', | ||||||
'', | ||||||
' def another(self):', | ||||||
' pass', | ||||||
] | ||||||
|
||||||
|
||||||
def test_patch_whitespace_match(): | ||||||
"""Test that the patch application succeeds when whitespace matches.""" | ||||||
# Original content has an empty line (no spaces) | ||||||
original_content = """class Example: | ||||||
def method(self): | ||||||
pass | ||||||
|
||||||
def another(self): | ||||||
pass""" | ||||||
|
||||||
# Patch expects an empty line (no spaces) | ||||||
patch_text = """diff --git a/example.py b/example.py | ||||||
index 1234567..89abcdef 100644 | ||||||
--- a/example.py | ||||||
+++ b/example.py | ||||||
@@ -2,6 +2,10 @@ class Example: | ||||||
def method(self): | ||||||
pass | ||||||
|
||||||
+ new_field: str = "value" | ||||||
+ | ||||||
def another(self): | ||||||
pass""" | ||||||
|
||||||
patch = next(parse_patch(patch_text)) | ||||||
new_content = apply_diff(patch, original_content) | ||||||
assert new_content == [ | ||||||
'class Example:', | ||||||
' def method(self):', | ||||||
' pass', | ||||||
'', | ||||||
' new_field: str = "value"', | ||||||
'', | ||||||
' def another(self):', | ||||||
' pass', | ||||||
] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment seems to contradict to the behavior?