Skip to content

feat(auth): Add consistent error messaging for invalid login credentials #9424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
okatu-loli wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −4
Open

feat(auth): Add consistent error messaging for invalid login credentials #9424

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions server/handles/auth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,9 @@ import (

var loginCache = cache.NewMemCache[int]()
var (
defaultDuration = time.Minute * 5
defaultTimes = 5
defaultDuration = time.Minute * 5
defaultTimes = 5
invalidLoginCredentialsMsg = "username or password is incorrect"
)

type LoginReq struct {
Expand Down Expand Up @@ -69,13 +70,13 @@ func loginHash(c *gin.Context, req *LoginReq) {
// check username
user, err := op.GetUserByName(req.Username)
if err != nil {
common.ErrorResp(c, err, 400)
common.ErrorStrResp(c, invalidLoginCredentialsMsg, 400)
loginCache.Set(ip, count+1)
return
}
// validate password hash
if err := user.ValidatePwdStaticHash(req.Password); err != nil {
common.ErrorResp(c, err, 400)
common.ErrorStrResp(c, invalidLoginCredentialsMsg, 400)
loginCache.Set(ip, count+1)
return
}
Expand Down
Loading