Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(github_release): add GitHub Release driver #7859

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vvtommy
Copy link

@vvtommy vvtommy commented Jan 21, 2025

实现 GitHub Release 存储驱动,可将 GitHub 仓库的 Releases 按版本号组织为目录树结构挂载到 AList。每个 Release 版本显示为包含对应二进制资产文件的文件夹。

参数名 类型 必填 说明
repo string GitHub 仓库名称,格式为 所有者/仓库名 (例: Alist-org/alist)
token string GitHub 个人访问令牌,需授予 repo 权限

挂载后目录结构示例:

/AList Releases/
├── v3.0.0
│   ├── alist-linux-amd64.tar.gz
│   ├── alist-windows-amd64.zip
│   └── md5.txt
├── v3.1.0
│   ├── alist-darwin-arm64.tar.gz
│   ├── alist-linux-armv7.tar.gz
│   └── sha256.txt
...

Image

@vvtommy vvtommy mentioned this pull request Jan 21, 2025
4 tasks
Comment on lines +9 to +13
initialRetryInterval = 500 * time.Millisecond
maxInterval = 1 * time.Minute
maxElapsedTime = 15 * time.Minute
randomizationFactor = 0.5
multiplier = 1.5

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

默认的时间太长了,之前这个 backoff 用在一个本地长时间的业务上,这个场景应对墙内网络故障,时间应该适当条短一些。应该调整成

Suggested change
initialRetryInterval = 500 * time.Millisecond
maxInterval = 1 * time.Minute
maxElapsedTime = 15 * time.Minute
randomizationFactor = 0.5
multiplier = 1.5
initialRetryInterval = 500 * time.Millisecond
maxInterval = 5 * time.Second
maxElapsedTime = 1 * time.Minute
randomizationFactor = 0.5
multiplier = 1.2

Copy link

@mattzhang233 mattzhang233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backoff 默认值是不是应该调整一下。

@itsHenry35
Copy link
Contributor

itsHenry35 commented Jan 23, 2025

这里加个latest的获取,然后作为一个其他tag并列的文件夹会不会更好呢?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants