Skip to content

chore: fix PR ABI validation logic (v2) #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aliorpse merged 2 commits into from
Jan 31, 2026
Merged

chore: fix PR ABI validation logic (v2) #109

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
016d248
chore: fix pr validation logic and add default output value
Aliorpse Jan 31, 2026
e7d4680
chore: address review comments on ABI validation workflow
Aliorpse Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions .github/workflows/pr_validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,13 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}

- name: Check Review Status
id: check_reviews
uses: actions/github-script@v7
with:
script: |
core.setOutput('should_run', 'false');

const { data: reviews } = await github.rest.pulls.listReviews({
owner: context.repo.owner,
repo: context.repo.repo,
Expand All @@ -33,14 +31,19 @@ jobs:
const states = Object.values(latestReviews);
const allApproved = states.length > 0 && states.every(state => state === 'APPROVED');

if (!allApproved) {
console.log("Skipping ABI validation because not all reviewers approved.");
core.setOutput('should_run', 'false');
} else {
if (allApproved) {
console.log("All reviewers approved. Proceeding with validation.");
core.setOutput('should_run', 'true');
} else {
console.log("Skipping ABI validation because not all reviewers approved.");
core.setOutput('should_run', 'false');
}

- uses: actions/checkout@v4
if: steps.check_reviews.outputs.should_run == 'true'
with:
ref: ${{ github.event.pull_request.head.sha }}

- name: Set up JDK
if: steps.check_reviews.outputs.should_run == 'true'
uses: actions/setup-java@v4
Expand All @@ -55,4 +58,4 @@ jobs:

- name: ABI Validation
if: steps.check_reviews.outputs.should_run == 'true'
run: ./gradlew checkLegacyAbi -Pfull-build=true --no-configuration-cache
run: ./gradlew checkLegacyAbi -Pfull-build=true --no-configuration-cache