Skip to content

[OGUI-1610] Update CI and DOC to Node22 #2741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mariscalromeroalejandro merged 1 commit into from
Feb 6, 2025
Merged

[OGUI-1610] Update CI and DOC to Node22 #2741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/control.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: '22.x'
- run: (cd Control; npm ci )
- run: (cd Control; npm test )
coverage:
Expand All @@ -29,7 +29,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: '22.x'
- run: (cd Control; npm ci )
- run: (cd Control; npm run coverage )
- run: (cd Control; ./node_modules/.bin/nyc report --reporter=text-lcov > coverage.lcov)
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/framework.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: '22.x'
- run: (cd Framework/Backend; openssl req -new -newkey rsa:2048 -days 365 -nodes -x509 -subj "/C=CH/ST=Test/L=Test/O=Tst/CN=localhost" -keyout test.key -out test.pem)
- run: (cd Framework; npm ci )
- run: (cd Framework; npm test )
Expand All @@ -29,7 +29,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: '22.x'
- run: (cd Framework; npm ci )
- run: (cd Framework; npm run coverage )
- run: (cd Framework; ./node_modules/.bin/nyc report --reporter=text-lcov > coverage.lcov)
Expand All @@ -46,7 +46,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: '22.x'
- run: cd Framework; npm ci
- run: cd Framework; npm test
control-compatibility:
Expand All @@ -62,7 +62,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: '22.x'
- run: (cd Framework; npm ci)
- run: (cd Control; npm ci)
- run: (cd Control; npm i --save ../Framework)
Expand All @@ -83,7 +83,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: '22.x'
- run: (cd Framework; npm ci)
- run: (cd QualityControl; npm ci)
- run: (cd QualityControl; npm i --save ../Framework)
Expand All @@ -103,7 +103,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: '22.x'
- run: (cd Framework; npm ci)
- run: (cd InfoLogger; npm ci)
- run: (cd InfoLogger; npm i --save ../Framework)
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/infologger.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: '22.x'
- run: (cd InfoLogger; npm ci )
- run: (cd InfoLogger; npm test )
coverage:
Expand All @@ -27,7 +27,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: '22.x'
- run: (cd InfoLogger; npm ci )
- run: (cd InfoLogger; npm run coverage )
- run: (cd InfoLogger; ./node_modules/.bin/nyc report --reporter=text-lcov > coverage.lcov)
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/qc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: '22.x'
- run: (cd QualityControl; npm ci )
- run: (cd QualityControl; npm run lint )
test:
Expand All @@ -30,7 +30,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: '22.x'
- run: (cd QualityControl; npm ci )
- run: (cd QualityControl; npm run test )
coverage:
Expand All @@ -42,7 +42,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: '22.x'
- run: (cd QualityControl; npm ci )
- run: (cd QualityControl; npm run coverage-lcov )
- name: Send codecov report for QualityControl
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: '22.x'
registry-url: 'https://registry.npmjs.org'
- name: Check released tag matches ALICE O2 naming pattern
run: |
Expand Down Expand Up @@ -52,7 +52,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: '22.x'
registry-url: 'https://registry.npmjs.org'
- name: Install production deps
run: npm install --only=production
Expand Down
2 changes: 1 addition & 1 deletion Control/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ This is a prototype of Control GUI. It aims to replace current ECS HI and provid
It communicates with [Control agent](https://github.com/AliceO2Group/Control) over gRPC.

## Requirements
- `nodejs` >= `16.x`
- `nodejs` >= `22.x`

## Installation
1. `git clone https://github.com/AliceO2Group/WebUi.git`
Expand Down
4 changes: 2 additions & 2 deletions Control/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Control/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"url": "https://github.com/AliceO2Group/WebUi.git"
},
"engines": {
"node": ">= 20.x"
"node": ">= 22.x"
},
"homepage": "https://alice-o2-project.web.cern.ch/",
"main": "index.js",
Expand Down
2 changes: 1 addition & 1 deletion Framework/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Framework/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"url": "https://github.com/AliceO2Group/WebUi.git"
},
"engines": {
"node": ">= 20.x"
"node": ">= 22.x"
},
"homepage": "https://alice-o2-project.web.cern.ch/",
"scripts": {
Expand Down
4 changes: 2 additions & 2 deletions InfoLogger/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion InfoLogger/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"url": "https://github.com/AliceO2Group/WebUi.git"
},
"engines": {
"node": ">= 20.x"
"node": ">= 22.x"
},
"homepage": "https://alice-o2-project.web.cern.ch/",
"scripts": {
Expand Down
4 changes: 2 additions & 2 deletions QualityControl/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion QualityControl/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"url": "https://github.com/AliceO2Group/WebUi.git"
},
"engines": {
"node": ">= 20.x"
"node": ">= 22.x"
},
"type": "module",
"homepage": "https://alice-o2-project.web.cern.ch/",
Expand Down