Skip to content

[OGUI-1594] Remove double conversion of grpc error and adapt to usage of errors from web-ui#2713

Merged
graduta merged 7 commits intodevfrom
bug/COG/OGUI-1594/remove-double-conversion-of-grpc-error
Jan 30, 2025
Merged

[OGUI-1594] Remove double conversion of grpc error and adapt to usage of errors from web-ui#2713
graduta merged 7 commits intodevfrom
bug/COG/OGUI-1594/remove-double-conversion-of-grpc-error

Conversation

@graduta
Copy link
Member

@graduta graduta commented Jan 8, 2025

I have JIRA issue created

  • branch and/or PR name(s) includes JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected
  • FLP integration tests were ran successful

PR which:

  • removes CustomError Classes from Control codebase and reuses them from web-ui
  • fixes a bug in which EnvironmentService was trying to convert an error from a gRPC error

@graduta graduta requested a review from pepijndik January 8, 2025 13:59
@graduta graduta self-assigned this Jan 8, 2025
…-1594/remove-double-conversion-of-grpc-error
@graduta graduta merged commit 52751c1 into dev Jan 30, 2025
8 of 9 checks passed
@graduta graduta deleted the bug/COG/OGUI-1594/remove-double-conversion-of-grpc-error branch January 30, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants