Skip to content

[PWGHF] Fix doULS pairs in Ds-h correlation task #14884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
scattaru wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[PWGHF] Fix doULS pairs in Ds-h correlation task #14884

scattaru wants to merge 3 commits into from
+32 −26

Conversation

@scattaru
Copy link
Contributor

@scattaru scattaru commented Feb 10, 2026

No description provided.

@github-actions github-actions bot added the pwghf PWG-HF label Feb 10, 2026
@github-actions github-actions bot changed the title Fix doULS pairs in Ds-h correlation task [PWGHF] Fix doULS pairs in Ds-h correlation task Feb 10, 2026
@singhra1994 singhra1994 enabled auto-merge (squash) February 10, 2026 09:51
@singhra1994 singhra1994 disabled auto-merge February 10, 2026 09:53
vkucera
vkucera reviewed Feb 10, 2026
View reviewed changes
@alibuild
Copy link
Collaborator

alibuild commented Feb 10, 2026

Error while checking build/O2Physics/o2 for 8239328 at 2026-02-10 11:00:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/14884-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCorrelationDsHadrons.cxx:707:13: error: 'doULSpai' was not declared in this scope; did you mean 'doULSpair'?
ninja: build stopped: subcommand failed.

Full log here.

@vkucera vkucera marked this pull request as draft February 10, 2026 10:13
@vkucera
Copy link
Collaborator

vkucera commented Feb 10, 2026

Your changes do not compile! You are supposed to test them before making a PR.

vkucera
vkucera reviewed Feb 10, 2026
View reviewed changes
@scattaru scattaru marked this pull request as ready for review February 10, 2026 10:50
@alibuild
Copy link
Collaborator

alibuild commented Feb 10, 2026

Error while checking build/O2Physics/o2 for f675dbb at 2026-02-10 13:24:

No log files found

Full log here.

@vkucera
Copy link
Collaborator

vkucera commented Feb 10, 2026

As a general comment, it seems to me that there is a lot of code duplication across the different process functions. Please consider a refactory to simplify the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera left review comments

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner

@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner

@stefanopolitano stefanopolitano Awaiting requested review from stefanopolitano stefanopolitano is a code owner

@singhra1994 singhra1994 Awaiting requested review from singhra1994 singhra1994 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scattaru @alibuild @vkucera