Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O2B-532] Minor improvements to selection dropdown #1828

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

martinboulais
Copy link
Collaborator

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • Radio buttons are displayed in selection dropdown when options are exclusives

Notable changes for developers:

  • Custom selector can be applied in selection dropdown options for values that are not CSS valid

Changes made to the database:

  • N/A

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 44.04%. Comparing base (86f5f39) to head (4b39d51).

Files with missing lines Patch % Lines
...nts/common/selection/dropdown/selectionDropdown.js 0.00% 7 Missing ⚠️
...blic/components/common/selection/SelectionModel.js 0.00% 4 Missing ⚠️
...lters/common/combinationOperatorChoiceComponent.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1828      +/-   ##
==========================================
- Coverage   44.06%   44.04%   -0.03%     
==========================================
  Files         889      889              
  Lines       15869    15878       +9     
  Branches     2993     2997       +4     
==========================================
  Hits         6993     6993              
- Misses       8876     8885       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinboulais martinboulais force-pushed the mboulais/O2B-532/minor-improvements-to-selection-dropdown branch from 302b3eb to c7b05e2 Compare January 7, 2025 18:34
@martinboulais martinboulais force-pushed the mboulais/O2B-532/minor-improvements-to-selection-dropdown branch from c7b05e2 to c03c84b Compare January 8, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant