Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O2B-532] Improve runs overview run definition filter #1825

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

martinboulais
Copy link
Collaborator

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • N/A

Notable changes for developers:

  • Run definition filter is now using the factorized filtering system

Changes made to the database:

  • N/A

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 3.83562% with 351 lines in your changes missing coverage. Please review.

Project coverage is 43.95%. Comparing base (86f5f39) to head (e7b2c37).

Files with missing lines Patch % Lines
...ponents/Filters/RunsFilter/EorReasonFilterModel.js 0.00% 53 Missing ⚠️
...s/common/filters/NumericalComparisonFilterModel.js 0.00% 31 Missing ⚠️
...public/components/Filters/common/FilteringModel.js 0.00% 28 Missing ⚠️
.../Filters/common/filters/ProcessedTextInputModel.js 0.00% 26 Missing ⚠️
...ib/public/views/Runs/Overview/RunsOverviewModel.js 0.00% 21 Missing ⚠️
...onents/Filters/RunsFilter/MagnetsFilteringModel.js 0.00% 18 Missing ⚠️
...c/components/Filters/RunsFilter/TimeRangeFilter.js 0.00% 17 Missing ⚠️
...nents/Filters/common/filters/RawTextFilterModel.js 0.00% 15 Missing ⚠️
.../public/components/runTypes/RunTypesFilterModel.js 0.00% 15 Missing ⚠️
...ponents/Filters/RunsFilter/DetectorsFilterModel.js 0.00% 14 Missing ⚠️
... and 25 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1825      +/-   ##
==========================================
- Coverage   44.06%   43.95%   -0.11%     
==========================================
  Files         889      892       +3     
  Lines       15869    15917      +48     
  Branches     2993     2987       -6     
==========================================
+ Hits         6993     6997       +4     
- Misses       8876     8920      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinboulais martinboulais force-pushed the mboulais/O2B-532/improve-runs-overview-run-definition-filter branch from 5fe9f8a to e8b872a Compare January 6, 2025 11:00
@martinboulais martinboulais force-pushed the mboulais/O2B-532/improve-runs-overview-run-definition-filter branch 2 times, most recently from 75cd203 to f550eb3 Compare January 9, 2025 09:41
@martinboulais martinboulais force-pushed the mboulais/O2B-532/improve-runs-overview-run-definition-filter branch from f550eb3 to 6ec2dab Compare January 12, 2025 18:50
@martinboulais martinboulais force-pushed the mboulais/O2B-532/improve-runs-overview-run-definition-filter branch from 6ec2dab to e7b2c37 Compare January 13, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant