[O2B-1139] Refresh tags list when a tag is updated/created #1805
+62
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1805 +/- ##
==========================================
- Coverage 44.02% 42.30% -1.72%
==========================================
Files 889 889
Lines 15863 15869 +6
Branches 2991 2993 +2
==========================================
- Hits 6983 6714 -269
- Misses 8880 9155 +275 ☔ View full report in Codecov by Sentry. |
…/Refreshtagslistwhenatagisupdated/created
…/Refreshtagslistwhenatagisupdated/created
martinboulais
requested changes
Dec 6, 2024
martinboulais
requested changes
Dec 11, 2024
…/Refreshtagslistwhenatagisupdated/created
martinboulais
requested changes
Jan 8, 2025
test/public/runs/detail.test.js
Outdated
Comment on lines
524
to
526
| (badges) => badges.map((badge) => ({ | ||
| backgroundColor: badge.style.backgroundColor, | ||
| })), |
There was a problem hiding this comment.
Suggested change
| (badges) => badges.map((badge) => ({ | |
| backgroundColor: badge.style.backgroundColor, | |
| })), | |
| (badges) => badges.map((badge) => badge.style.backgroundColor), |
test/public/runs/detail.test.js
Outdated
|
|
||
| badges = await getRunTagsBadges(); | ||
|
|
||
| expect(badges[0].backgroundColor == expectedBgColorBefore).to.be.true; |
There was a problem hiding this comment.
Suggested change
| expect(badges[0].backgroundColor == expectedBgColorBefore).to.be.true; | |
| expect(badges[0]).to.equal(expectedBgColorBefore); |
Doing so, you have explicit error message when values are not equal, something like expected rgb(...) to equal rgb(...)
When you expect a value of an array, putting an expect on the array length is often a good idea
test/public/runs/detail.test.js
Outdated
| await goToRunDetails(page, 106); | ||
| badges = await getRunTagsBadges(); | ||
|
|
||
| expect(badges[0].backgroundColor == expectedBgColorAfter).to.be.true; |
There was a problem hiding this comment.
Suggested change
| expect(badges[0].backgroundColor == expectedBgColorAfter).to.be.true; | |
| expect(badges[0]).to.equal(expectedBgColorAfter); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a JIRA ticket
Notable changes for users:
-tag colours will now update when looking at run details
Notable changes for developers:
Changes made to the database: