Fix and improve TPC Loopers implementation#15013
Merged
sawenzel merged 1 commit intoAliceO2Group:devfrom Feb 4, 2026
Merged
Conversation
Collaborator
jackal1-66
commented
Feb 3, 2026
- Moved the TPCLoopers inclusion to Generator.cxx
- Made forward declaration for GenTPCLoopers
- Switched to normal pointer instead of unique_ptr (destroyed in Generator destructor) ==> moved outside ifdef scope, this was the main cause of the segmentation issue when using the external generators, such as Update tune from SCCR to QCDCR for pO and OO O2DPG#2256
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
sawenzel
reviewed
Feb 3, 2026
5b5f4b4 to
315600e
Compare
sawenzel
approved these changes
Feb 4, 2026
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 315600e at 2026-02-04 15:13: Full log here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.