-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Pagination for quiz app #34
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, You've done good work but writing such long code for something that can be done in 2-4 lines is not a good practice. I would recommend you to go through this and remove unwanted code -
https://github.com/diyajaiswal11/Grocery-Task/blob/main/GroceryTask/groceries/views.py
…tAPIView) for better implementation of pagination
Hey Diya please check the changes i have made. Let me know if it is matching your interest or not.
|
Hey @diyajaiswal11 please review this pr:) |
@hasanmdarif This can be done with just around 7-10 lines of code. You should not make changes to other files. Put up a new PR only with the code that is required for this functionality |
Added pagination.py for quiz app
Closes: #29
I have added pagination for quiz app.
used PageNumberPagination.
You can type http://127.0.0.1:8000/quiz/question/array/?page_size=1 to see the changes.
page_size can be any number you desire.
Please check the code and let me know if i need to improve it.
PS:- Kindly add relevant lebels for GSSOC'21 on issue #29