Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API server SSH connection check #3441

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Add API server SSH connection check #3441

merged 1 commit into from
Oct 25, 2023

Conversation

arkid15r
Copy link
Contributor

Issue Number

Resolves #3437

Purpose/Implementation Notes

Add an explicit API server availability check by a SSH session establishing attempt. Exit if the API server is unavailable via SSH.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@arkid15r arkid15r requested a review from davidsmejia October 25, 2023 15:59
davidsmejia
davidsmejia approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@davidsmejia davidsmejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkid15r arkid15r merged commit d0b17b9 into dev Oct 25, 2023
4 of 17 checks passed
@arkid15r arkid15r deleted the ark/3437-api-server-wont-start branch October 25, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsmejia davidsmejia davidsmejia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API server won't start after deploy
2 participants
@arkid15r @davidsmejia