Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GH workflows: add test_base to test_api_base dependencies #3400

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Update GH workflows: add test_base to test_api_base dependencies #3400

merged 2 commits into from
Sep 28, 2023

Conversation

arkid15r
Copy link
Contributor

Purpose/Implementation Notes

Make api base image tests explicitly wait for base image tests completion as migrations images need that.

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

davidsmejia
davidsmejia approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@davidsmejia davidsmejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkid15r arkid15r changed the base branch from dev to ark/move-smasher-jobs-to-larger-runners September 28, 2023 18:30
Base automatically changed from ark/move-smasher-jobs-to-larger-runners to dev September 28, 2023 18:59
@arkid15r arkid15r merged commit b3e5f66 into dev Sep 28, 2023
2 of 3 checks passed
@arkid15r arkid15r deleted the ark/make-test-api-depend-on-base branch September 28, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsmejia davidsmejia davidsmejia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arkid15r @davidsmejia