Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement data request tracking #3387

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Conversation

arkid15r
Copy link
Contributor

Issue Number

#3361

Purpose/Implementation Notes

Add a command that gathers/shows stats based on a accession code list.
The areas of interest include attempted/available experiments (total and broken down by source) as well as attempted/available samples (total and broken down by source).
The total number of jobs created includes all job types.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Add a command that gathers/shows stats based on a accession code list.
The areas of interest include attempted/available experiments
(total and broken down by source) as well as attempted/available samples
(total and broken down by source).
The total number of jobs created includes all job types.
Copy link
Contributor

@davidsmejia davidsmejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, could we just add support for s3:// urls

Copy link
Contributor Author

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated PR based on your comments, PTAL

Copy link
Contributor

@davidsmejia davidsmejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkid15r arkid15r merged commit bc365b2 into dev Sep 26, 2023
@arkid15r arkid15r deleted the ark/3361-tracking-data-requests branch September 26, 2023 14:43
@arkid15r arkid15r mentioned this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants