-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade angular V7.0.3 and enhancements #89
base: angular-cli
Are you sure you want to change the base?
Conversation
Enhance event emmiter "authorised" and "unAuthorised" with permissions states
@yd021976 Can You please resolve conflicts so I can look into it :-) But i don't have much time right now. And Thank You For this funcitonality |
@AlexKhymenko Thank you, can you give me write access to the repository or the conflict files so I can resolve conflicts ? |
@yd021976 Actually there is a message that 'this conflicts are too complex to resolve in the web editor' Can You merge master to Your branch? |
@AlexKhymenko Hi, i've fixed conflicts. But seems that as I modified the project structure to be Angular 7 compliant, it breaks your travis CI build (actually, package.json has been moved to "./application" instead of being in ./ before ==> I think there is a lot of other changes in my PR that will break Travis CI. |
@AlexKhymenko Hi again :-) I confirm that the new project structure definitively break your Travis CI. Thank you ! |
@AlexKhymenko , I've made some changes in package.json so that Travis CI should run with success. Unfortunately, Angular V6/7 needs Node js >= v8.9 Could you please change the Travis CI config with a required node version compatible with angular >= V6 ? (i.e Node V8.9) Thank you |
@AlexKhymenko oupss... Sorry for my requests about Travis CI, I've just learn that I can customize the depedencies in project file ".travis.yml" Now my last commit have passed all checks successfully :-) |
@yd021976 Thank You!! Very much i will Look asap. Just have a lot of work :-( |
@AlexKhymenko Hi ! FYI, I added 11 new Jasmine spec tests for my improvements :-) |
@yd021976 Thank You Again. Just There are a lot of changes and not so much time :-( |
Hi,
I submit some changes :