Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade angular V7.0.3 and enhancements #89

Open
wants to merge 24 commits into
base: angular-cli
Choose a base branch
from

Conversation

yd021976
Copy link

@yd021976 yd021976 commented Nov 1, 2018

Hi,

I submit some changes :

  • Upgrade workspace to angular V7.0.0 compliant (use of library project)
  • Some enhancements :
  1. Provide "permission states" in custom strategy callback
  2. Provide "permissions states" in event emitters (authorized and unauthorized)

Yann added 2 commits October 27, 2018 19:34
Enhance event emmiter "authorised" and "unAuthorised" with permissions states
@yd021976 yd021976 changed the title Upgrade angular V7.0.3 and enhance Upgrade angular V7.0.3 and enhancements Nov 1, 2018
@yd021976
Copy link
Author

yd021976 commented Nov 4, 2018

Finalized enhancements + re-configure some tests + run all tests with success (398 specs with 0 failure)
image

@AlexKhymenko
Copy link
Owner

@yd021976 Can You please resolve conflicts so I can look into it :-) But i don't have much time right now. And Thank You For this funcitonality

@yd021976
Copy link
Author

yd021976 commented Nov 6, 2018

@AlexKhymenko Thank you, can you give me write access to the repository or the conflict files so I can resolve conflicts ?
image

@AlexKhymenko
Copy link
Owner

@yd021976 Actually there is a message that 'this conflicts are too complex to resolve in the web editor' Can You merge master to Your branch?

@yd021976
Copy link
Author

yd021976 commented Nov 7, 2018

@AlexKhymenko Hi, i've fixed conflicts. But seems that as I modified the project structure to be Angular 7 compliant, it breaks your travis CI build (actually, package.json has been moved to "./application" instead of being in ./ before ==> I think there is a lot of other changes in my PR that will break Travis CI.

@yd021976
Copy link
Author

yd021976 commented Nov 7, 2018

@AlexKhymenko Hi again :-) I confirm that the new project structure definitively break your Travis CI.
When you have time can you update travis CI to validate my PR ?

Thank you !

@yd021976
Copy link
Author

yd021976 commented Nov 7, 2018

@AlexKhymenko , I've made some changes in package.json so that Travis CI should run with success. Unfortunately, Angular V6/7 needs Node js >= v8.9

Could you please change the Travis CI config with a required node version compatible with angular >= V6 ? (i.e Node V8.9)

Thank you

@yd021976
Copy link
Author

yd021976 commented Nov 7, 2018

@AlexKhymenko oupss... Sorry for my requests about Travis CI, I've just learn that I can customize the depedencies in project file ".travis.yml"

Now my last commit have passed all checks successfully :-)

@AlexKhymenko
Copy link
Owner

@yd021976 Thank You!! Very much i will Look asap. Just have a lot of work :-(

@yd021976
Copy link
Author

yd021976 commented Nov 9, 2018

@AlexKhymenko Hi ! FYI, I added 11 new Jasmine spec tests for my improvements :-)

@AlexKhymenko
Copy link
Owner

@yd021976 Thank You Again. Just There are a lot of changes and not so much time :-(

@AlexKhymenko AlexKhymenko changed the base branch from master to angular-cli June 5, 2019 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants