Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed libudev install and get command #100

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

antony060206
Copy link

removed two lines from the build file in the workflow that installs the linux package called libudev-dev.

removed two lines from the build file in the workflow that installs the linux package called libudev-dev.
@antony060206 antony060206 added the enhancement New feature or request label Jan 19, 2025
@antony060206 antony060206 requested a review from DrakBoul January 19, 2025 06:05
@antony060206 antony060206 changed the title removed libudev insal and apt-get command removed libudev install and get command Jan 19, 2025
@antony060206
Copy link
Author

kinda confused here, there seems to be a check failure after the builddev installation has been removed. Is this supposed to happen?

@antony060206 antony060206 added question Further information is requested and removed enhancement New feature or request labels Jan 19, 2025
@DrakBoul
Copy link
Contributor

kinda confused here, there seems to be a check failure after the builddev installation has been removed. Is this supposed to happen?

That's a good question. If you look at why the build failed (You can do this by clicking details of the build) its because we need that system package to use the rust crate "libudev-sys". Although we do not use this crate directly we do use another crate called "serialport" that relies on it.

Essentially when I changed over using different crates I forgot to remove this from the ex3_shared_libs/interface/Cargo.toml file. You should try removing the line that tells rust to build the serialport crate with our project. this should fix the problems.

@DrakBoul
Copy link
Contributor

Also, don't change the tag (You changed it from enhancement to question). It's not a super big deal but this tag just represents what the PR is doing, so making it a question doesnt make much sense. If you want to ask a question, you can add a reviewer and then make a comment (Even mentioning the particular person the question is aimed to within the comment).

@DrakBoul DrakBoul added enhancement New feature or request and removed question Further information is requested labels Jan 20, 2025
Copy link
Contributor

@DrakBoul DrakBoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Just remove the serialport dependency in the interface directory toml file. My bad I forgot to remove that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants