Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid SSR memory leak #948

Open
wants to merge 1 commit into
base: v-tooltip-2
Choose a base branch
from

Conversation

rdsfj
Copy link

@rdsfj rdsfj commented Mar 31, 2023

hello πŸ™‹β€β™€οΈ

using the package v-tooltip@2, I encountered some problems with memory leaks in a server side rendering setup.
I tracked down the problems to usage of v-tooltip and its object of default options. I couldn't quite figure out the reason, but I suspect that vue instances are not garbage collected because they are somehow connected to this object.

Anyway, moving the default options to a factory resolves the problem. The default object is not exposed outside the package, so as far as I can tell this shouldn't change any functionalit.

It would be great to see a new version of v-tooltip released even though floating-vue is the successor.
Let me know what you think and if I can help!
Simon

@rdsfj rdsfj changed the title fix: Move default options to factory fix: Avoid SSR memory leak Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant