Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for old python versions #595

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

packi
Copy link
Contributor

@packi packi commented Jul 6, 2023

Debian just dropped 3.10 in their latest release.

@packi packi force-pushed the packi-remove-old-python-versions branch 2 times, most recently from 9b10f16 to 57a9350 Compare July 6, 2023 08:07
Debian just dropped 3.10 in their latest release.
@packi packi force-pushed the packi-remove-old-python-versions branch from 57a9350 to bf5e852 Compare July 6, 2023 08:17
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #595 (57a9350) into main (6dce5bf) will decrease coverage by 0.11%.
The diff coverage is n/a.

❗ Current head 57a9350 differs from pull request most recent head bf5e852. Consider uploading reports for the commit bf5e852 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #595      +/-   ##
==========================================
- Coverage   91.31%   91.20%   -0.11%     
==========================================
  Files          32       32              
  Lines        4684     4684              
==========================================
- Hits         4277     4272       -5     
- Misses        407      412       +5     

see 2 files with indirect coverage changes

@rdunklau
Copy link
Contributor

rdunklau commented Jul 6, 2023

Is it really necessary to drop old versions ? A lot of users may be using older distros, as long as it doesn't cost us too much it would be nice to keep pghoard working for them.

@giacomo-alzetta-aiven
Copy link

Dropping python3.7 is fine since it is EOLed (recent rohmu versions have dropped support as well), but I wouldn't just drop 3.8-3.10 without any particular reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants