handle a graceful shutdown on request #594
Draft
+97
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kathia-barahona
commented
Jul 4, 2023
| # wait for all queues to be emptied | ||
| self._wait_for_queue_to_be_emptied(self.compression_queue, "compression") | ||
| self._wait_for_queue_to_be_emptied(self.transfer_queue, "transfer") | ||
| self._wait_for_queue_to_be_emptied(self.wal_file_deletion_queue, "wal_file_deletion") |
There was a problem hiding this comment.
comment wal_file_deletion_queue is not super high prio, but makes sure we do not re-compress or re-upload files when pghoard is restarted (startup_walk)
kathia-barahona
force-pushed
the
graceful_shutdown
branch
from
2e5b1c6
to
2db19a6
Compare
|
:/ Build failing, seems rohmu got updated again (using Protocol, not supported on 3.7) |
To be noted that Python 3.7 reached EOL a week ago. |
rdunklau
reviewed
Jul 6, 2023
[BF-1358]
kathia-barahona
force-pushed
the
graceful_shutdown
branch
from
2db19a6
to
b9e7bfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
Handles graceful shutdowns by making sure all compressed files get uploaded
(considers also partial files)Edit: renaming partial files is dangerous, after testing I didn't got the expected results (duplicated segments on different timelines)
Why this way
Shutting down pghoard can be dangerous, leading to missed segments if not all information was uploaded. To avoid this, its better to make sure all tasks/events were completed.