Updating tests with distributed mode #338
Merged
+88
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnatolyPopov
requested changes
Nov 10, 2024
...ce-connector/src/integration-test/java/io/aiven/kafka/connect/s3/source/IntegrationTest.java
Outdated
Show resolved
Hide resolved
...ce-connector/src/integration-test/java/io/aiven/kafka/connect/s3/source/IntegrationTest.java
Outdated
Show resolved
Hide resolved
...ce-connector/src/integration-test/java/io/aiven/kafka/connect/s3/source/IntegrationBase.java
Show resolved
Hide resolved
| props.put(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG, "earliest"); | ||
|
|
||
| final Map<String, Object> messages = new HashMap<>(); | ||
| Map<String, Object> offsetRec; |
There was a problem hiding this comment.
This variable declaration is redundant here and unnecessary widening the variable scope. It can be declared together with the assignment
| while (messages.size() < expectedMessageCount) { | ||
| final ConsumerRecords<byte[], byte[]> records = consumer.poll(5L); | ||
| for (final ConsumerRecord<byte[], byte[]> record : records) { | ||
| offsetRec = OBJECT_MAPPER.readValue(new String(record.value(), StandardCharsets.UTF_8), // NOPMD |
There was a problem hiding this comment.
Conversion to String seems to be redundant, objectMapper is able to parse byte arrays.
...ce-connector/src/integration-test/java/io/aiven/kafka/connect/s3/source/IntegrationTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
integration tests now run in connect distributed mode
verify offset storage keys