tests: use asyncio_mode = auto [DDB-901] #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelynch
force-pushed
the
joelynch/fix-for-aiven-core
branch
from
a6d86d9 to
4ddfb10
Compare
alanfranz
previously requested changes
Mar 11, 2024
There was a problem hiding this comment.
tests/unit/coordinator/plugins/test_base.py::test_upload_step_uses_new_request_if_supported[no_feature] SKIPPED (async def function and no async plugin installed (see warnings))
tests/unit/coordinator/plugins/test_base.py::test_upload_step_uses_new_request_if_supported[validate_file_hashes] SKIPPED (async def function and no async plugin installed (see warnings))
So, async tests don't run nevertheless; this could be the intended behaviour (maybe we just want to run those in aiven-core) but the commit message is misleading, as it would imply that we'd be running those tests by now; so I think we should either add an async plugin or amend the commit and pr message.
joelynch
force-pushed
the
joelynch/fix-for-aiven-core
branch
3 times, most recently
from
c97957b to
ee6c9f5
Compare
This means that we do not miss tests by accidentally forgetting the pytest mark. Additionally this is needed to run tests using aiven-core pytest.
joelynch
force-pushed
the
joelynch/fix-for-aiven-core
branch
from
ee6c9f5 to
05c8668
Compare
joelynch
changed the title
kmichel-aiven
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that we do not miss tests by accidentally forgetting the pytest mark. Additionally this is needed to run tests using aiven-core pytest.
Additionally, I removed a duplicate github actions workflow.